Re: [Xen-devel] [RFC 22/22] xen/arm: gic-v3: Add support of vGICv2 when available

2015-06-25 Thread Julien Grall
Hi Ian, On 08/06/2015 12:01, Ian Campbell wrote: On Fri, 2015-06-05 at 17:35 +0100, Julien Grall wrote: */ static void gicv3_enable_sre(void) { uint32_t val; val = READ_SYSREG32(ICC_SRE_EL2); -val |= GICC_SRE_EL2_SRE | GICC_SRE_EL2_ENEL1; +val |= GICC_SRE_EL2_SRE;

Re: [Xen-devel] [RFC 22/22] xen/arm: gic-v3: Add support of vGICv2 when available

2015-06-08 Thread Ian Campbell
On Fri, 2015-06-05 at 17:35 +0100, Julien Grall wrote: > >> */ > >> static void gicv3_enable_sre(void) > >> { > >> uint32_t val; > >> > >> val = READ_SYSREG32(ICC_SRE_EL2); > >> -val |= GICC_SRE_EL2_SRE | GICC_SRE_EL2_ENEL1; > >> +val |= GICC_SRE_EL2_SRE; > >> > >> W

Re: [Xen-devel] [RFC 22/22] xen/arm: gic-v3: Add support of vGICv2 when available

2015-06-05 Thread Julien Grall
On 05/06/15 13:48, Ian Campbell wrote: > On Fri, 2015-05-08 at 14:29 +0100, Julien Grall wrote: >> * Modify the GICv3 driver to recognize a such device. I wasn't able >> to find a register which tell if GICv2 is supported on GICv3. The only >> way to find it seems to check if the DT node provid

Re: [Xen-devel] [RFC 22/22] xen/arm: gic-v3: Add support of vGICv2 when available

2015-06-05 Thread Ian Campbell
On Fri, 2015-05-08 at 14:29 +0100, Julien Grall wrote: > * Modify the GICv3 driver to recognize a such device. I wasn't able > to find a register which tell if GICv2 is supported on GICv3. The only > way to find it seems to check if the DT node provides GICC and GICV. I think that's the way...

[Xen-devel] [RFC 22/22] xen/arm: gic-v3: Add support of vGICv2 when available

2015-05-08 Thread Julien Grall
* Modify the GICv3 driver to recognize a such device. I wasn't able to find a register which tell if GICv2 is supported on GICv3. The only way to find it seems to check if the DT node provides GICC and GICV. * Disable access to ICC_SRE_EL1 to guest using vGICv2 * The LR is slightly different