Re: [Xen-devel] [PATCHv6 4/5] gnttab: remove unnecessary grant table locks

2015-04-23 Thread Jan Beulich
>>> On 22.04.15 at 18:00, wrote: > This is safe because: a) the grant table version only changes once > from 0 to 1 or 2; gnttab_set_version() also allows it to transition between 1 and 2 afaics. > @@ -919,18 +914,15 @@ __gnttab_unmap_common( > } > > op->map = &maptrack_entry(lgt, op

Re: [Xen-devel] [PATCHv6 4/5] gnttab: remove unnecessary grant table locks

2015-04-23 Thread Tim Deegan
At 17:00 +0100 on 22 Apr (1429722035), David Vrabel wrote: > @@ -2642,8 +2615,6 @@ __gnttab_swap_grant_ref(grant_ref_t ref_a, grant_ref_t > ref_b) > */ > return rc; > > -spin_lock(>->lock); > - Now that this lock is gone, is anything stopping us racing against another CPU

[Xen-devel] [PATCHv6 4/5] gnttab: remove unnecessary grant table locks

2015-04-22 Thread David Vrabel
From: Malcolm Crossley The grant table lock is not required to protect reads of the table version, the active entry array, or the map track array. This is safe because: a) the grant table version only changes once from 0 to 1 or 2; b) the active entry array only grows; and c) the map track array