Re: [Xen-devel] [PATCHv6 1/3] rwlock: Add per-cpu reader-writer lock infrastructure

2016-01-22 Thread Ian Campbell
On Fri, 2016-01-22 at 14:30 +, Malcolm Crossley wrote: > On 22/01/16 14:22, Ian Campbell wrote: > > On Fri, 2016-01-22 at 14:16 +, Malcolm Crossley wrote: > > > On 22/01/16 13:54, Ian Campbell wrote: > > > > On Fri, 2016-01-22 at 13:41 +, Malcolm Crossley wrote: > > > > >   > > > > > Ch

Re: [Xen-devel] [PATCHv6 1/3] rwlock: Add per-cpu reader-writer lock infrastructure

2016-01-22 Thread Malcolm Crossley
On 22/01/16 14:22, Ian Campbell wrote: > On Fri, 2016-01-22 at 14:16 +, Malcolm Crossley wrote: >> On 22/01/16 13:54, Ian Campbell wrote: >>> On Fri, 2016-01-22 at 13:41 +, Malcolm Crossley wrote: Changes since v5: - Fix compilation on ARM >>> >>> This was the removal of so

Re: [Xen-devel] [PATCHv6 1/3] rwlock: Add per-cpu reader-writer lock infrastructure

2016-01-22 Thread Ross Lagerwall
On 01/22/2016 02:16 PM, Malcolm Crossley wrote: On 22/01/16 13:54, Ian Campbell wrote: On Fri, 2016-01-22 at 13:41 +, Malcolm Crossley wrote: Changes since v5: - Fix compilation on ARM This was the removal of some spurious "&", I think? Yeah, I forgot to keep the macro's in sync. ARM a

Re: [Xen-devel] [PATCHv6 1/3] rwlock: Add per-cpu reader-writer lock infrastructure

2016-01-22 Thread Ian Campbell
On Fri, 2016-01-22 at 14:16 +, Malcolm Crossley wrote: > On 22/01/16 13:54, Ian Campbell wrote: > > On Fri, 2016-01-22 at 13:41 +, Malcolm Crossley wrote: > > >   > > > Changes since v5: > > > - Fix compilation on ARM > > > > This was the removal of some spurious "&", I think? > > Yeah, I

Re: [Xen-devel] [PATCHv6 1/3] rwlock: Add per-cpu reader-writer lock infrastructure

2016-01-22 Thread Malcolm Crossley
On 22/01/16 13:54, Ian Campbell wrote: > On Fri, 2016-01-22 at 13:41 +, Malcolm Crossley wrote: >> >> Changes since v5: >> - Fix compilation on ARM > > This was the removal of some spurious "&", I think? Yeah, I forgot to keep the macro's in sync. ARM also needed the xen/percpu.h header fi

Re: [Xen-devel] [PATCHv6 1/3] rwlock: Add per-cpu reader-writer lock infrastructure

2016-01-22 Thread Ian Campbell
On Fri, 2016-01-22 at 13:41 +, Malcolm Crossley wrote: >  > Changes since v5: > - Fix compilation on ARM This was the removal of some spurious "&", I think? Acked-by: Ian Campbell Thanks for catching this! ___ Xen-devel mailing list Xen-devel@l

[Xen-devel] [PATCHv6 1/3] rwlock: Add per-cpu reader-writer lock infrastructure

2016-01-22 Thread Malcolm Crossley
Per-cpu read-write locks allow for the fast path read case to have low overhead by only setting/clearing a per-cpu variable for using the read lock. The per-cpu read fast path also avoids locked compare swap operations which can be particularly slow on coherent multi-socket systems, particularly if