Re: [Xen-devel] [PATCHv4 1/2] x86/ept: invalidate guest physical mappings on VMENTER

2015-12-15 Thread George Dunlap
On 14/12/15 14:39, David Vrabel wrote: > If a guest allocates a page and the tlbflush_timestamp on the page > indicates that a TLB flush of the previous owner is required, only the > linear and combined mappings are invalidated. The guest-physical > mappings are not invalidated. > > This is curre

Re: [Xen-devel] [PATCHv4 1/2] x86/ept: invalidate guest physical mappings on VMENTER

2015-12-14 Thread George Dunlap
On 14/12/15 15:09, Andrew Cooper wrote: > On 14/12/15 15:00, David Vrabel wrote: >> On 14/12/15 14:52, Andrew Cooper wrote: >>> On 14/12/15 14:39, David Vrabel wrote: diff --git a/xen/arch/x86/mm/p2m-ept.c b/xen/arch/x86/mm/p2m-ept.c index eef0372..6e0cf89 100644 --- a/xen/arch/x86/m

Re: [Xen-devel] [PATCHv4 1/2] x86/ept: invalidate guest physical mappings on VMENTER

2015-12-14 Thread Andrew Cooper
On 14/12/15 15:00, David Vrabel wrote: > On 14/12/15 14:52, Andrew Cooper wrote: >> On 14/12/15 14:39, David Vrabel wrote: >>> diff --git a/xen/arch/x86/mm/p2m-ept.c b/xen/arch/x86/mm/p2m-ept.c >>> index eef0372..6e0cf89 100644 >>> --- a/xen/arch/x86/mm/p2m-ept.c >>> +++ b/xen/arch/x86/mm/p2m-ept.c

Re: [Xen-devel] [PATCHv4 1/2] x86/ept: invalidate guest physical mappings on VMENTER

2015-12-14 Thread David Vrabel
On 14/12/15 14:52, Andrew Cooper wrote: > On 14/12/15 14:39, David Vrabel wrote: >> diff --git a/xen/arch/x86/mm/p2m-ept.c b/xen/arch/x86/mm/p2m-ept.c >> index eef0372..6e0cf89 100644 >> --- a/xen/arch/x86/mm/p2m-ept.c >> +++ b/xen/arch/x86/mm/p2m-ept.c [...] >> +on_selected_cpus(d->domain_dirt

Re: [Xen-devel] [PATCHv4 1/2] x86/ept: invalidate guest physical mappings on VMENTER

2015-12-14 Thread Andrew Cooper
On 14/12/15 14:39, David Vrabel wrote: > diff --git a/xen/arch/x86/mm/p2m-ept.c b/xen/arch/x86/mm/p2m-ept.c > index eef0372..6e0cf89 100644 > --- a/xen/arch/x86/mm/p2m-ept.c > +++ b/xen/arch/x86/mm/p2m-ept.c > @@ -1089,9 +1089,10 @@ static void ept_memory_type_changed(struct p2m_domain > *p2m) >

[Xen-devel] [PATCHv4 1/2] x86/ept: invalidate guest physical mappings on VMENTER

2015-12-14 Thread David Vrabel
If a guest allocates a page and the tlbflush_timestamp on the page indicates that a TLB flush of the previous owner is required, only the linear and combined mappings are invalidated. The guest-physical mappings are not invalidated. This is currently safe because the EPT code ensures that the gue