Re: [Xen-devel] [PATCHv2 5/5] evtchn: pad struct evtchn to 64 bytes

2015-06-16 Thread Julien Grall
On 16/06/15 14:13, David Vrabel wrote: > On 16/06/15 13:57, Julien Grall wrote: >> On 16/06/15 12:59, Jan Beulich wrote: >> On 16.06.15 at 13:14, wrote: On 15/06/2015 16:48, David Vrabel wrote: > diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h > index 44ea92d..a0ff9

Re: [Xen-devel] [PATCHv2 5/5] evtchn: pad struct evtchn to 64 bytes

2015-06-16 Thread David Vrabel
On 16/06/15 13:57, Julien Grall wrote: > On 16/06/15 12:59, Jan Beulich wrote: > On 16.06.15 at 13:14, wrote: >>> On 15/06/2015 16:48, David Vrabel wrote: diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h index 44ea92d..a0ff9d2 100644 --- a/xen/include/xen/sched.h >

Re: [Xen-devel] [PATCHv2 5/5] evtchn: pad struct evtchn to 64 bytes

2015-06-16 Thread Julien Grall
On 16/06/15 12:59, Jan Beulich wrote: On 16.06.15 at 13:14, wrote: >> On 15/06/2015 16:48, David Vrabel wrote: >>> diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h >>> index 44ea92d..a0ff9d2 100644 >>> --- a/xen/include/xen/sched.h >>> +++ b/xen/include/xen/sched.h >>> @@ -129,7

Re: [Xen-devel] [PATCHv2 5/5] evtchn: pad struct evtchn to 64 bytes

2015-06-16 Thread Jan Beulich
>>> On 16.06.15 at 13:14, wrote: > On 15/06/2015 16:48, David Vrabel wrote: >> diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h >> index 44ea92d..a0ff9d2 100644 >> --- a/xen/include/xen/sched.h >> +++ b/xen/include/xen/sched.h >> @@ -129,7 +129,7 @@ struct evtchn >> #endif >>

Re: [Xen-devel] [PATCHv2 5/5] evtchn: pad struct evtchn to 64 bytes

2015-06-16 Thread Julien Grall
Hi David, On 15/06/2015 16:48, David Vrabel wrote: diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h index 44ea92d..a0ff9d2 100644 --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h @@ -129,7 +129,7 @@ struct evtchn #endif } ssid; #endif -}; +} __attribute__((alig

Re: [Xen-devel] [PATCHv2 5/5] evtchn: pad struct evtchn to 64 bytes

2015-06-16 Thread Jan Beulich
>>> On 15.06.15 at 17:48, wrote: > The number of struct evtchn in a page must be a power of two. Under > some workloads performance is improved slightly by padding struct > evtchn to 64 bytes (a cache line), thus putting the per-channel locks > into their own cache line. > > This does not decrea

[Xen-devel] [PATCHv2 5/5] evtchn: pad struct evtchn to 64 bytes

2015-06-15 Thread David Vrabel
The number of struct evtchn in a page must be a power of two. Under some workloads performance is improved slightly by padding struct evtchn to 64 bytes (a cache line), thus putting the per-channel locks into their own cache line. This does not decrease the number of struct evtchn's per-page. Si