Re: [Xen-devel] [PATCHv1 5/8] xen/balloon: rationalize memory hotplug stats

2015-06-26 Thread David Vrabel
On 25/06/15 22:31, Daniel Kiper wrote: > On Thu, Jun 25, 2015 at 08:54:45PM +0200, Daniel Kiper wrote: > > It looks that balloon_stats.total_pages is used only in memory hotplug case. > Please do references (and definition) to it inside #ifdef > CONFIG_XEN_BALLOON_MEMORY_HOTPLUG > like it is done

Re: [Xen-devel] [PATCHv1 5/8] xen/balloon: rationalize memory hotplug stats

2015-06-25 Thread Daniel Kiper
On Thu, Jun 25, 2015 at 08:54:45PM +0200, Daniel Kiper wrote: > On Thu, Jun 25, 2015 at 08:38:36PM +0200, Daniel Kiper wrote: > > On Thu, Jun 25, 2015 at 06:11:00PM +0100, David Vrabel wrote: > > > The stats used for memory hotplug make no sense and are fiddled with > > > in odd ways. Remove them

Re: [Xen-devel] [PATCHv1 5/8] xen/balloon: rationalize memory hotplug stats

2015-06-25 Thread Daniel Kiper
On Thu, Jun 25, 2015 at 08:38:36PM +0200, Daniel Kiper wrote: > On Thu, Jun 25, 2015 at 06:11:00PM +0100, David Vrabel wrote: > > The stats used for memory hotplug make no sense and are fiddled with > > in odd ways. Remove them and introduce total_pages to track the total > > number of pages (both

Re: [Xen-devel] [PATCHv1 5/8] xen/balloon: rationalize memory hotplug stats

2015-06-25 Thread Daniel Kiper
On Thu, Jun 25, 2015 at 06:11:00PM +0100, David Vrabel wrote: > The stats used for memory hotplug make no sense and are fiddled with > in odd ways. Remove them and introduce total_pages to track the total > number of pages (both populated and unpopulated) including those within > hotplugged region

[Xen-devel] [PATCHv1 5/8] xen/balloon: rationalize memory hotplug stats

2015-06-25 Thread David Vrabel
The stats used for memory hotplug make no sense and are fiddled with in odd ways. Remove them and introduce total_pages to track the total number of pages (both populated and unpopulated) including those within hotplugged regions (note that this includes not yet onlined pages). This will be usefu