Re: [Xen-devel] [PATCH v9 for Xen 4.7 3/4] libxl: enable per-VCPU parameter for RTDS

2016-04-06 Thread Dario Faggioli
On Wed, 2016-04-06 at 20:49 +0100, Wei Liu wrote: > On Wed, Apr 06, 2016 at 02:41:31PM -0500, Chong Li wrote: > > On Wed, Apr 6, 2016 at 2:30 PM, Wei Liu > > wrote: > > > On Wed, Apr 06, 2016 at 02:20:55PM -0500, Chong Li wrote: > > > Not sure what kind of sanity check you were thinking about. But

Re: [Xen-devel] [PATCH v9 for Xen 4.7 3/4] libxl: enable per-VCPU parameter for RTDS

2016-04-06 Thread Wei Liu
On Wed, Apr 06, 2016 at 02:41:31PM -0500, Chong Li wrote: > On Wed, Apr 6, 2016 at 2:30 PM, Wei Liu wrote: > > On Wed, Apr 06, 2016 at 02:20:55PM -0500, Chong Li wrote: > >> On Wed, Apr 6, 2016 at 1:54 PM, Andrew Cooper > >> wrote: > >> > On 06/04/16 17:41, Chong Li wrote: > >> >> On Wed, Apr 6,

Re: [Xen-devel] [PATCH v9 for Xen 4.7 3/4] libxl: enable per-VCPU parameter for RTDS

2016-04-06 Thread Chong Li
On Wed, Apr 6, 2016 at 2:30 PM, Wei Liu wrote: > On Wed, Apr 06, 2016 at 02:20:55PM -0500, Chong Li wrote: >> On Wed, Apr 6, 2016 at 1:54 PM, Andrew Cooper >> wrote: >> > On 06/04/16 17:41, Chong Li wrote: >> >> On Wed, Apr 6, 2016 at 11:36 AM, Dario Faggioli >> >> wrote: >> >>> On Wed, 2016-04

Re: [Xen-devel] [PATCH v9 for Xen 4.7 3/4] libxl: enable per-VCPU parameter for RTDS

2016-04-06 Thread Wei Liu
On Wed, Apr 06, 2016 at 02:20:55PM -0500, Chong Li wrote: > On Wed, Apr 6, 2016 at 1:54 PM, Andrew Cooper > wrote: > > On 06/04/16 17:41, Chong Li wrote: > >> On Wed, Apr 6, 2016 at 11:36 AM, Dario Faggioli > >> wrote: > >>> On Wed, 2016-04-06 at 16:38 +0100, Ian Jackson wrote: > Ian Jackso

Re: [Xen-devel] [PATCH v9 for Xen 4.7 3/4] libxl: enable per-VCPU parameter for RTDS

2016-04-06 Thread Andrew Cooper
On 06/04/16 20:20, Chong Li wrote: > On Wed, Apr 6, 2016 at 1:54 PM, Andrew Cooper > wrote: >> On 06/04/16 17:41, Chong Li wrote: >>> On Wed, Apr 6, 2016 at 11:36 AM, Dario Faggioli >>> wrote: On Wed, 2016-04-06 at 16:38 +0100, Ian Jackson wrote: > Ian Jackson writes ("Re: [PATCH v9 for

Re: [Xen-devel] [PATCH v9 for Xen 4.7 3/4] libxl: enable per-VCPU parameter for RTDS

2016-04-06 Thread Chong Li
On Wed, Apr 6, 2016 at 1:54 PM, Andrew Cooper wrote: > On 06/04/16 17:41, Chong Li wrote: >> On Wed, Apr 6, 2016 at 11:36 AM, Dario Faggioli >> wrote: >>> On Wed, 2016-04-06 at 16:38 +0100, Ian Jackson wrote: Ian Jackson writes ("Re: [PATCH v9 for Xen 4.7 3/4] libxl: enable per-VCPU par

Re: [Xen-devel] [PATCH v9 for Xen 4.7 3/4] libxl: enable per-VCPU parameter for RTDS

2016-04-06 Thread Andrew Cooper
On 06/04/16 17:41, Chong Li wrote: > On Wed, Apr 6, 2016 at 11:36 AM, Dario Faggioli > wrote: >> On Wed, 2016-04-06 at 16:38 +0100, Ian Jackson wrote: >>> Ian Jackson writes ("Re: [PATCH v9 for Xen 4.7 3/4] libxl: enable >>> per-VCPU parameter for RTDS"): Dario points out on irc that perhaps

Re: [Xen-devel] [PATCH v9 for Xen 4.7 3/4] libxl: enable per-VCPU parameter for RTDS

2016-04-06 Thread Chong Li
On Wed, Apr 6, 2016 at 11:36 AM, Dario Faggioli wrote: > On Wed, 2016-04-06 at 16:38 +0100, Ian Jackson wrote: >> Ian Jackson writes ("Re: [PATCH v9 for Xen 4.7 3/4] libxl: enable >> per-VCPU parameter for RTDS"): >> > >> > Dario points out on irc that perhaps the problem is that I didn't >> > app

Re: [Xen-devel] [PATCH v9 for Xen 4.7 3/4] libxl: enable per-VCPU parameter for RTDS

2016-04-06 Thread Dario Faggioli
On Wed, 2016-04-06 at 16:38 +0100, Ian Jackson wrote: > Ian Jackson writes ("Re: [PATCH v9 for Xen 4.7 3/4] libxl: enable > per-VCPU parameter for RTDS"): > > > > Dario points out on irc that perhaps the problem is that I didn't > > apply 2/4.  I wasn't CC'd on 2/4, so I foolishly assumed it was a

Re: [Xen-devel] [PATCH v9 for Xen 4.7 3/4] libxl: enable per-VCPU parameter for RTDS

2016-04-06 Thread Ian Jackson
Ian Jackson writes ("Re: [PATCH v9 for Xen 4.7 3/4] libxl: enable per-VCPU parameter for RTDS"): > Dario points out on irc that perhaps the problem is that I didn't > apply 2/4. I wasn't CC'd on 2/4, so I foolishly assumed it was a > hypervisor patch (and the HV parts are already in tree). > > I

Re: [Xen-devel] [PATCH v9 for Xen 4.7 3/4] libxl: enable per-VCPU parameter for RTDS

2016-04-06 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH v9 for Xen 4.7 3/4] libxl: enable per-VCPU parameter for RTDS"): > On Wed, Apr 06, 2016 at 03:55:25PM +0100, Ian Jackson wrote: > > libxl.c: In function 'sched_rtds_vcpu_get': > > libxl.c:5980:5: error: implicit declaration of function > > 'xc_sched_rtds_vcpu_get' [-We

Re: [Xen-devel] [PATCH v9 for Xen 4.7 3/4] libxl: enable per-VCPU parameter for RTDS

2016-04-06 Thread Wei Liu
On Wed, Apr 06, 2016 at 03:55:25PM +0100, Ian Jackson wrote: > Ian Jackson writes ("Re: [PATCH v9 for Xen 4.7 3/4] libxl: enable per-VCPU > parameter for RTDS"): > > Wei Liu writes ("Re: [PATCH v9 for Xen 4.7 3/4] libxl: enable per-VCPU > > parameter for RTDS"): > > > These two functions LGTM, so

Re: [Xen-devel] [PATCH v9 for Xen 4.7 3/4] libxl: enable per-VCPU parameter for RTDS

2016-04-06 Thread Ian Jackson
Ian Jackson writes ("Re: [PATCH v9 for Xen 4.7 3/4] libxl: enable per-VCPU parameter for RTDS"): > Wei Liu writes ("Re: [PATCH v9 for Xen 4.7 3/4] libxl: enable per-VCPU > parameter for RTDS"): > > These two functions LGTM, so I shall ack this patch again: > > > > Acked-by: Wei Liu > > I hav

Re: [Xen-devel] [PATCH v9 for Xen 4.7 3/4] libxl: enable per-VCPU parameter for RTDS

2016-04-06 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH v9 for Xen 4.7 3/4] libxl: enable per-VCPU parameter for RTDS"): > On Thu, Mar 31, 2016 at 11:59:45PM -0500, Chong Li wrote: > > Add libxl_vcpu_sched_params_get/set and sched_rtds_vcpu_get/set > > functions to support per-VCPU settings. > > > > Signed-off-by: Chong Li

Re: [Xen-devel] [PATCH v9 for Xen 4.7 3/4] libxl: enable per-VCPU parameter for RTDS

2016-04-01 Thread Wei Liu
On Thu, Mar 31, 2016 at 11:59:45PM -0500, Chong Li wrote: > Add libxl_vcpu_sched_params_get/set and sched_rtds_vcpu_get/set > functions to support per-VCPU settings. > > Signed-off-by: Chong Li > Signed-off-by: Meng Xu > Signed-off-by: Sisu Xi > > Acked-by: Wei Liu This should have been drop

Re: [Xen-devel] [PATCH v9 for Xen 4.7 3/4] libxl: enable per-VCPU parameter for RTDS

2016-04-01 Thread Dario Faggioli
On Thu, 2016-03-31 at 23:59 -0500, Chong Li wrote: > Add libxl_vcpu_sched_params_get/set and sched_rtds_vcpu_get/set > functions to support per-VCPU settings. > > Signed-off-by: Chong Li > Signed-off-by: Meng Xu > Signed-off-by: Sisu Xi > > Acked-by: Wei Liu > Reviewed-by: Dario Faggioli > Y

[Xen-devel] [PATCH v9 for Xen 4.7 3/4] libxl: enable per-VCPU parameter for RTDS

2016-03-31 Thread Chong Li
Add libxl_vcpu_sched_params_get/set and sched_rtds_vcpu_get/set functions to support per-VCPU settings. Signed-off-by: Chong Li Signed-off-by: Meng Xu Signed-off-by: Sisu Xi Acked-by: Wei Liu Reviewed-by: Dario Faggioli --- Changes on PATCH v8: 1) Add libxl_vcpu_sched_params_get_all() and sc