Re: [Xen-devel] [PATCH v9 12/13] test_x86_emulator.c: Add tests for #GP usage

2015-02-25 Thread Don Slutz
On 02/25/15 03:30, Jan Beulich wrote: On 24.02.15 at 19:29, wrote: >> +/* >> + * Test out special #GP handling for the VMware port 0x5658. >> + * This is done in two "modes", j=0 and j=1. Testing 4 >> + * instructions (all the basic PIO) in both modes. >> + * >> + * T

Re: [Xen-devel] [PATCH v9 12/13] test_x86_emulator.c: Add tests for #GP usage

2015-02-25 Thread Jan Beulich
>>> On 24.02.15 at 19:29, wrote: > +/* > + * Test out special #GP handling for the VMware port 0x5658. > + * This is done in two "modes", j=0 and j=1. Testing 4 > + * instructions (all the basic PIO) in both modes. > + * > + * The port used is based on j. > + * > +

Re: [Xen-devel] [PATCH v9 12/13] test_x86_emulator.c: Add tests for #GP usage

2015-02-24 Thread Don Slutz
On 02/24/15 10:38, Jan Beulich wrote: On 17.02.15 at 00:05, wrote: >> Signed-off-by: Don Slutz > > There's a whole lot of stuff being added here, and I easily can't see > where delivery of a #GP would actually be tested. Clearly I need more comments. Short form is that j=1 is the #GP test

Re: [Xen-devel] [PATCH v9 12/13] test_x86_emulator.c: Add tests for #GP usage

2015-02-24 Thread Jan Beulich
>>> On 17.02.15 at 00:05, wrote: > Signed-off-by: Don Slutz There's a whole lot of stuff being added here, and I easily can't see where delivery of a #GP would actually be tested. Please explain here what the tests are supposed to test and why emulops_gp needs all the function pointers you're ad

[Xen-devel] [PATCH v9 12/13] test_x86_emulator.c: Add tests for #GP usage

2015-02-16 Thread Don Slutz
Signed-off-by: Don Slutz --- tools/tests/x86_emulator/test_x86_emulator.c | 155 +++ 1 file changed, 155 insertions(+) diff --git a/tools/tests/x86_emulator/test_x86_emulator.c b/tools/tests/x86_emulator/test_x86_emulator.c index 02a9f0a..985c80e 100644 --- a/tools/tests