Re: [Xen-devel] [PATCH v8.1 17/27] xsplice: Add support for bug frames.

2016-04-22 Thread Konrad Rzeszutek Wilk
On Fri, Apr 22, 2016 at 04:58:19AM -0600, Jan Beulich wrote: > >>> On 22.04.16 at 12:54, wrote: > > The thing that makes it "safe" (in lieu of your comment about > > re-ordering) is that the trap code does: > > > > 1289 /* WARN, BUG or ASSERT: decode the filename pointer and line > > number.

Re: [Xen-devel] [PATCH v8.1 17/27] xsplice: Add support for bug frames.

2016-04-22 Thread Jan Beulich
>>> On 22.04.16 at 12:54, wrote: > The thing that makes it "safe" (in lieu of your comment about > re-ordering) is that the trap code does: > > 1289 /* WARN, BUG or ASSERT: decode the filename pointer and line > number. */ > 1290 filename = bug_ptr(bug); > 1291 if ( !is_kernel(filena

Re: [Xen-devel] [PATCH v8.1 17/27] xsplice: Add support for bug frames.

2016-04-22 Thread Konrad Rzeszutek Wilk
On Fri, Apr 22, 2016 at 04:28:42AM -0600, Jan Beulich wrote: > >>> On 22.04.16 at 12:10, wrote: > > On Thu, Apr 21, 2016 at 12:49:09AM -0600, Jan Beulich wrote: > >> >>> On 21.04.16 at 02:29, wrote: > >> > On Tue, Apr 19, 2016 at 02:17:35PM -0600, Jan Beulich wrote: > >> >> >>> Konrad Rzeszutek W

Re: [Xen-devel] [PATCH v8.1 17/27] xsplice: Add support for bug frames.

2016-04-22 Thread Jan Beulich
>>> On 22.04.16 at 12:10, wrote: > On Thu, Apr 21, 2016 at 12:49:09AM -0600, Jan Beulich wrote: >> >>> On 21.04.16 at 02:29, wrote: >> > On Tue, Apr 19, 2016 at 02:17:35PM -0600, Jan Beulich wrote: >> >> >>> Konrad Rzeszutek Wilk 04/14/16 12:02 AM >>> >> >> >+bool_t is_patch(const void *ptr) >>

Re: [Xen-devel] [PATCH v8.1 17/27] xsplice: Add support for bug frames.

2016-04-22 Thread Konrad Rzeszutek Wilk
On Thu, Apr 21, 2016 at 12:49:09AM -0600, Jan Beulich wrote: > >>> On 21.04.16 at 02:29, wrote: > > On Tue, Apr 19, 2016 at 02:17:35PM -0600, Jan Beulich wrote: > >> >>> Konrad Rzeszutek Wilk 04/14/16 12:02 AM >>> > >> >+bool_t is_patch(const void *ptr) > >> >+{ > >> >+struct payload *data; >

Re: [Xen-devel] [PATCH v8.1 17/27] xsplice: Add support for bug frames.

2016-04-20 Thread Jan Beulich
>>> On 21.04.16 at 02:29, wrote: > On Tue, Apr 19, 2016 at 02:17:35PM -0600, Jan Beulich wrote: >> >>> Konrad Rzeszutek Wilk 04/14/16 12:02 AM >>> >> >+bool_t is_patch(const void *ptr) >> >+{ >> >+struct payload *data; >> >> You guess it: const. >> >> >+/* >> >+ * No locking since t

Re: [Xen-devel] [PATCH v8.1 17/27] xsplice: Add support for bug frames.

2016-04-20 Thread Konrad Rzeszutek Wilk
On Tue, Apr 19, 2016 at 02:17:35PM -0600, Jan Beulich wrote: > >>> Konrad Rzeszutek Wilk 04/14/16 12:02 AM >>> > >+bool_t is_patch(const void *ptr) > >+{ > >+struct payload *data; > > You guess it: const. > > >+/* > >+ * No locking since this list is only ever changed during apply or

Re: [Xen-devel] [PATCH v8.1 17/27] xsplice: Add support for bug frames.

2016-04-19 Thread Jan Beulich
>>> Konrad Rzeszutek Wilk 04/14/16 12:02 AM >>> >+bool_t is_patch(const void *ptr) >+{ >+struct payload *data; You guess it: const. >+/* >+ * No locking since this list is only ever changed during apply or revert >+ * context. >+ */ What if you crash while applying or revert

[Xen-devel] [PATCH v8.1 17/27] xsplice: Add support for bug frames.

2016-04-13 Thread Konrad Rzeszutek Wilk
From: Ross Lagerwall Add support for handling bug frames contained with xsplice modules. If a trap occurs search either the kernel bug table or an applied payload's bug table depending on the instruction pointer. Signed-off-by: Ross Lagerwall Signed-off-by: Konrad Rzeszutek Wilk Reviewed-by: A