Re: [Xen-devel] [PATCH v8.1 11/27] xsplice: Implement payload loading

2016-04-22 Thread Jan Beulich
>>> On 21.04.16 at 18:47, wrote: > On April 21, 2016 11:36:24 AM EDT, Jan Beulich wrote: > On 21.04.16 at 17:15, wrote: >>> On Wed, Apr 20, 2016 at 11:59:34AM -0400, Konrad Rzeszutek Wilk >>wrote: > >@@ -29,6 +30,13 @@ struct payload { > >uint32_t state; /

Re: [Xen-devel] [PATCH v8.1 11/27] xsplice: Implement payload loading

2016-04-21 Thread Konrad Rzeszutek Wilk
On April 21, 2016 11:36:24 AM EDT, Jan Beulich wrote: On 21.04.16 at 17:15, wrote: >> On Wed, Apr 20, 2016 at 11:59:34AM -0400, Konrad Rzeszutek Wilk >wrote: >>> > >@@ -29,6 +30,13 @@ struct payload { >>> > >uint32_t state; /* One of the >XSPLICE_STATE_*. */ >>> >

Re: [Xen-devel] [PATCH v8.1 11/27] xsplice: Implement payload loading

2016-04-21 Thread Jan Beulich
>>> On 21.04.16 at 17:15, wrote: > On Wed, Apr 20, 2016 at 11:59:34AM -0400, Konrad Rzeszutek Wilk wrote: >> > >@@ -29,6 +30,13 @@ struct payload { >> > >uint32_t state; /* One of the XSPLICE_STATE_*. >> > */ >> > >int32_t rc; /* 0 or -XEN_E

Re: [Xen-devel] [PATCH v8.1 11/27] xsplice: Implement payload loading

2016-04-21 Thread Konrad Rzeszutek Wilk
On Wed, Apr 20, 2016 at 11:59:34AM -0400, Konrad Rzeszutek Wilk wrote: > > >+void arch_xsplice_free_payload(void *va) > > >+{ > > >+vfree_xen(va); > > >+} > > > > What is the idea behind having this hook (instead of generic code just > > calling > > vfree_xen() [or really just vfree()])? > >

Re: [Xen-devel] [PATCH v8.1 11/27] xsplice: Implement payload loading

2016-04-20 Thread Jan Beulich
>>> On 20.04.16 at 19:36, wrote: > On Apr 20, 2016 6:05 PM, "Jan Beulich" wrote: >> >> >>> Konrad Rzeszutek Wilk 04/20/16 6:00 PM >>> >> >> >+ size_t pages; /* Total pages for [text,rw,ro]_addr */ >> >> >> >> Why size_t and not just unsigned int? >> > >> >Oh. I was somehow under the impression y

Re: [Xen-devel] [PATCH v8.1 11/27] xsplice: Implement payload loading

2016-04-20 Thread Konrad Rzeszutek Wilk
On Apr 20, 2016 6:05 PM, "Jan Beulich" wrote: > > >>> Konrad Rzeszutek Wilk 04/20/16 6:00 PM >>> > >> >+ size_t pages; /* Total pages for [text,rw,ro]_addr */ > >> > >> Why size_t and not just unsigned int? > > > >Oh. I was somehow under the impression you liked size_t more than > >unsignged int!

Re: [Xen-devel] [PATCH v8.1 11/27] xsplice: Implement payload loading

2016-04-20 Thread Jan Beulich
>>> Konrad Rzeszutek Wilk 04/20/16 6:00 PM >>> >> >+ size_t pages; /* Total pages for [text,rw,ro]_addr */ >> >> Why size_t and not just unsigned int? > >Oh. I was somehow under the impression you liked size_t more than >unsignged int! I will change it over. When used where actually talking abou

Re: [Xen-devel] [PATCH v8.1 11/27] xsplice: Implement payload loading

2016-04-20 Thread Konrad Rzeszutek Wilk
> >+void arch_xsplice_free_payload(void *va) > >+{ > >+vfree_xen(va); > >+} > > What is the idea behind having this hook (instead of generic code just calling > vfree_xen() [or really just vfree()])? To have an symmetry with the allocation one. I don't know enough about ARM to know whether th

Re: [Xen-devel] [PATCH v8.1 11/27] xsplice: Implement payload loading

2016-04-17 Thread Jan Beulich
>>> Konrad Rzeszutek Wilk 04/14/16 12:04 AM >>> >--- a/xen/arch/x86/Makefile >+++ b/xen/arch/x86/Makefile >@@ -64,6 +64,7 @@ obj-y += vm_event.o >obj-y += xstate.o > >obj-$(crash_debug) += gdbstub.o >+obj-$(CONFIG_XSPLICE) += xsplice.o This should be added in the main section, somewhere ahea

[Xen-devel] [PATCH v8.1 11/27] xsplice: Implement payload loading

2016-04-13 Thread Konrad Rzeszutek Wilk
From: Ross Lagerwall Add support for loading xsplice payloads. This is somewhat similar to the Linux kernel module loader, implementing the following steps: - Verify the elf file. - Parse the elf file. - Allocate a region of memory mapped within a free area of [xen_virt_end, XEN_VIRT_END]. - Co