On Tue, Feb 16, Ian Jackson wrote:
> Olaf Hering writes ("Re: [PATCH v8 3/5] libxl: add support for vscsi"):
> > On Mon, Feb 15, Ian Jackson wrote:
> > > One reason you might define a virtual controller with no devices yet
> > > is so that you have a stable and pre-expected device path for any
> >
Olaf Hering writes ("Re: [PATCH v8 3/5] libxl: add support for vscsi"):
> On Mon, Feb 15, Ian Jackson wrote:
> > One reason you might define a virtual controller with no devices yet
> > is so that you have a stable and pre-expected device path for any
> > actual targets you choose to hotplug later.
On Mon, Feb 15, Ian Jackson wrote:
> One reason you might define a virtual controller with no devices yet
> is so that you have a stable and pre-expected device path for any
> actual targets you choose to hotplug later.
Would it be acceptable to reuse the devid as the "group index"?
The various v
Wei Liu writes ("Re: [PATCH v8 3/5] libxl: add support for vscsi"):
> If it is mandated by hardware that empty scsi controller doesn't
> exist, that's of course fine. But I don't think it is mandated in
> reality? I can have no disk attached to a controller and that should
> be fine.
For the avoid
On Mon, Feb 15, 2016 at 04:24:38PM +0100, Olaf Hering wrote:
> On Mon, Feb 15, Wei Liu wrote:
>
> > > I think yes, DEFINE_DEVICES_ADD has to be used somewhere.
> > I'm confused. You're joking, right? "Has to be used somewhere" is not
> > a justification for having it in this particular place.
>
>
On Mon, Feb 15, Wei Liu wrote:
> > I think yes, DEFINE_DEVICES_ADD has to be used somewhere.
> I'm confused. You're joking, right? "Has to be used somewhere" is not
> a justification for having it in this particular place.
What would be the appropriate place? I think its there since I started
wor
On Fri, Feb 12, 2016 at 07:24:59PM +0100, Olaf Hering wrote:
[...]
>
> > > +if (libxl__xs_directory(gc, XBT_NULL, be_path, &be_dirs)) {
> > > +rc = libxl__device_vscsi_reconfigure_add(egc, aodev,
> > > &vscsi_saved, &d_config, be_path);
> > > +if (rc)
> > > +goto o
On Fri, Feb 12, Wei Liu wrote:
> There seems to be a lot of places in this patch where the lines are
> longer than 80 characters. I'm not going to point them out one by one.
> Can you fix as many of those as you can where sensible?
Many lines are slightly longer than 80 chars already, as can be s
I notice you posted several enquiries in your previous patch, but I'm
not sure if any of them still requires answers because you seemed to
have posted answers to your own enquiries. I skip all of them and start
from this version.
There seems to be a lot of places in this patch where the lines are
Port pvscsi support from xend to libxl:
vscsi=['pdev,vdev{,options}']
xl scsi-attach
xl scsi-detach
xl scsi-list
Signed-off-by: Olaf Hering
Cc: Ian Jackson
Cc: Stefano Stabellini
Cc: Ian Campbell
Cc: Wei Liu
---
docs/man/xl.cfg.pod.5| 55 +++
docs/man/xl.pod.1
10 matches
Mail list logo
