Re: [Xen-devel] [PATCH v8 05/13] libxl: Load guest BIOS from file

2016-08-24 Thread Wei Liu
On Tue, Aug 23, 2016 at 04:00:24PM -0400, Doug Goldstein wrote: > On 8/18/16 10:13 AM, Wei Liu wrote: > > > > > +if (info->device_model_version == LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN) > > { > > +if (info->u.hvm.system_firmware) { > > +bios_filename = info->u.hvm.system_f

Re: [Xen-devel] [PATCH v8 05/13] libxl: Load guest BIOS from file

2016-08-23 Thread Doug Goldstein
On 8/18/16 10:13 AM, Wei Liu wrote: > > +if (info->device_model_version == LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN) { > +if (info->u.hvm.system_firmware) { > +bios_filename = info->u.hvm.system_firmware; > +} else { > +switch (info->u.hvm.bios) { > +

Re: [Xen-devel] [PATCH v8 05/13] libxl: Load guest BIOS from file

2016-08-22 Thread Wei Liu
On Mon, Aug 22, 2016 at 04:09:07PM +0100, Andrew Cooper wrote: > On 22/08/16 15:26, Wei Liu wrote: > > On Mon, Aug 22, 2016 at 02:26:11PM +0100, Andrew Cooper wrote: > >> On 22/08/16 14:13, Wei Liu wrote: > >>> On Fri, Aug 19, 2016 at 03:43:00PM +0100, Andrew Cooper wrote: > On 18/08/16 15:13,

Re: [Xen-devel] [PATCH v8 05/13] libxl: Load guest BIOS from file

2016-08-22 Thread Andrew Cooper
On 22/08/16 15:26, Wei Liu wrote: > On Mon, Aug 22, 2016 at 02:26:11PM +0100, Andrew Cooper wrote: >> On 22/08/16 14:13, Wei Liu wrote: >>> On Fri, Aug 19, 2016 at 03:43:00PM +0100, Andrew Cooper wrote: On 18/08/16 15:13, Wei Liu wrote: > From: Anthony PERARD > > The path to the B

Re: [Xen-devel] [PATCH v8 05/13] libxl: Load guest BIOS from file

2016-08-22 Thread Wei Liu
On Mon, Aug 22, 2016 at 02:26:11PM +0100, Andrew Cooper wrote: > On 22/08/16 14:13, Wei Liu wrote: > > On Fri, Aug 19, 2016 at 03:43:00PM +0100, Andrew Cooper wrote: > >> On 18/08/16 15:13, Wei Liu wrote: > >>> From: Anthony PERARD > >>> > >>> The path to the BIOS blob can be overriden by the xl's

Re: [Xen-devel] [PATCH v8 05/13] libxl: Load guest BIOS from file

2016-08-22 Thread Andrew Cooper
On 22/08/16 14:13, Wei Liu wrote: > On Fri, Aug 19, 2016 at 03:43:00PM +0100, Andrew Cooper wrote: >> On 18/08/16 15:13, Wei Liu wrote: >>> From: Anthony PERARD >>> >>> The path to the BIOS blob can be overriden by the xl's >>> bios_path_override option, or provided by u.hvm.bios_firmware in the >

Re: [Xen-devel] [PATCH v8 05/13] libxl: Load guest BIOS from file

2016-08-22 Thread Wei Liu
On Fri, Aug 19, 2016 at 03:43:00PM +0100, Andrew Cooper wrote: > On 18/08/16 15:13, Wei Liu wrote: > > From: Anthony PERARD > > > > The path to the BIOS blob can be overriden by the xl's > > bios_path_override option, or provided by u.hvm.bios_firmware in the > > domain_build_info struct by other

Re: [Xen-devel] [PATCH v8 05/13] libxl: Load guest BIOS from file

2016-08-19 Thread Andrew Cooper
On 18/08/16 15:13, Wei Liu wrote: > From: Anthony PERARD > > The path to the BIOS blob can be overriden by the xl's > bios_path_override option, or provided by u.hvm.bios_firmware in the > domain_build_info struct by other libxl user. > > Signed-off-by: Anthony PERARD > Acked-by: Wei Liu This i

[Xen-devel] [PATCH v8 05/13] libxl: Load guest BIOS from file

2016-08-18 Thread Wei Liu
From: Anthony PERARD The path to the BIOS blob can be overriden by the xl's bios_path_override option, or provided by u.hvm.bios_firmware in the domain_build_info struct by other libxl user. Signed-off-by: Anthony PERARD Acked-by: Wei Liu --- Changes in V6: - use goto for error handling of lib