Re: [Xen-devel] [PATCH v8 04/24] x86: refactor psr: implement CPU init and free flow.

2017-03-12 Thread Yi Sun
On 17-03-10 01:56:04, Jan Beulich wrote: > >>> On 10.03.17 at 02:32, wrote: > > On 17-03-08 07:56:54, Jan Beulich wrote: > >> >>> On 15.02.17 at 09:49, wrote: [...] > >> > +if ( !cpu_has(¤t_cpu_data, X86_FEATURE_PQE) ) > >> > >> Do you really mean to not universally check the global (boot C

Re: [Xen-devel] [PATCH v8 04/24] x86: refactor psr: implement CPU init and free flow.

2017-03-10 Thread Jan Beulich
>>> On 10.03.17 at 02:32, wrote: > On 17-03-08 07:56:54, Jan Beulich wrote: >> >>> On 15.02.17 at 09:49, wrote: >> > -static int psr_cpu_prepare(unsigned int cpu) >> > +static void cpu_init_work(void) >> > +{ >> > +struct psr_socket_info *info; >> > +unsigned int socket; >> > +unsigne

Re: [Xen-devel] [PATCH v8 04/24] x86: refactor psr: implement CPU init and free flow.

2017-03-09 Thread Yi Sun
On 17-03-08 07:56:54, Jan Beulich wrote: > >>> On 15.02.17 at 09:49, wrote: [...] > > -static int psr_cpu_prepare(unsigned int cpu) > > +static void cpu_init_work(void) > > +{ > > +struct psr_socket_info *info; > > +unsigned int socket; > > +unsigned int cpu = smp_processor_id(); > >

Re: [Xen-devel] [PATCH v8 04/24] x86: refactor psr: implement CPU init and free flow.

2017-03-08 Thread Jan Beulich
>>> On 15.02.17 at 09:49, wrote: > This patch implements the CPU init and free flow including L3 CAT > initialization and feature list free. I think from the final-effect-of-the-patch point of view the L3 CAT aspect is more relevant, so that's what should appear in the title. > @@ -136,11 +140,8

Re: [Xen-devel] [PATCH v8 04/24] x86: refactor psr: implement CPU init and free flow.

2017-02-27 Thread Wei Liu
On Mon, Feb 27, 2017 at 02:42:31PM +0800, Yi Sun wrote: > On 17-02-26 17:41:08, Wei Liu wrote: > > On Wed, Feb 15, 2017 at 04:49:19PM +0800, Yi Sun wrote: > > > This patch implements the CPU init and free flow including L3 CAT > > > initialization and feature list free. > > > > > > Signed-off-by:

Re: [Xen-devel] [PATCH v8 04/24] x86: refactor psr: implement CPU init and free flow.

2017-02-27 Thread Jan Beulich
>>> Wei Liu 02/26/17 6:41 PM >>> >On Wed, Feb 15, 2017 at 04:49:19PM +0800, Yi Sun wrote: >> +static void free_feature(struct psr_socket_info *info) >> +{ >> +struct feat_node *feat, *next; >> + >> +if ( !info ) >> +return; >> + >> +/* >> + * Free resources of features. But

Re: [Xen-devel] [PATCH v8 04/24] x86: refactor psr: implement CPU init and free flow.

2017-02-26 Thread Yi Sun
On 17-02-26 17:41:08, Wei Liu wrote: > On Wed, Feb 15, 2017 at 04:49:19PM +0800, Yi Sun wrote: > > This patch implements the CPU init and free flow including L3 CAT > > initialization and feature list free. > > > > Signed-off-by: Yi Sun > > Either you need to use a separate patch to move cpuid_c

Re: [Xen-devel] [PATCH v8 04/24] x86: refactor psr: implement CPU init and free flow.

2017-02-26 Thread Wei Liu
On Wed, Feb 15, 2017 at 04:49:19PM +0800, Yi Sun wrote: > This patch implements the CPU init and free flow including L3 CAT > initialization and feature list free. > > Signed-off-by: Yi Sun Either you need to use a separate patch to move cpuid_count_leaf or you should state it is moved in the co

[Xen-devel] [PATCH v8 04/24] x86: refactor psr: implement CPU init and free flow.

2017-02-15 Thread Yi Sun
This patch implements the CPU init and free flow including L3 CAT initialization and feature list free. Signed-off-by: Yi Sun --- v8: - remove unused parameter of psr_cpu_prepare. - add comments in cpu_fini_work. - coding style fix. --- xen/arch/x86/cpuid.c| 6 -- xen/a