Re: [Xen-devel] [PATCH v7.1 07/24] x86/mm: Introduce modify_xen_mappings()

2016-04-11 Thread Andrew Cooper
On 11/04/16 18:18, Jan Beulich wrote: On 11.04.16 at 16:04, wrote: >> @@ -5964,6 +5976,10 @@ void destroy_xen_mappings(unsigned long s, unsigned >> long e) >> unsigned int i; >> unsigned long v = s; >> >> +/* Set of valid PTE bits which may be altered. */ >> +#define FLAGS_M

Re: [Xen-devel] [PATCH v7.1 07/24] x86/mm: Introduce modify_xen_mappings()

2016-04-11 Thread Jan Beulich
>>> On 11.04.16 at 16:04, wrote: > @@ -5964,6 +5976,10 @@ void destroy_xen_mappings(unsigned long s, unsigned > long e) > unsigned int i; > unsigned long v = s; > > +/* Set of valid PTE bits which may be altered. */ > +#define FLAGS_MASK (_PAGE_NX|_PAGE_RW|_PAGE_PRESENT) > +n

Re: [Xen-devel] [PATCH v7.1 07/24] x86/mm: Introduce modify_xen_mappings()

2016-04-11 Thread George Dunlap
On 11/04/16 15:04, Andrew Cooper wrote: > To simply change the permissions on existing Xen mappings. The existing > destroy_xen_mappings() is altered to support a change the PTE permissions. > > A new destroy_xen_mappings() is introduced, as the special case of not passing > _PAGE_PRESENT to modi

[Xen-devel] [PATCH v7.1 07/24] x86/mm: Introduce modify_xen_mappings()

2016-04-11 Thread Andrew Cooper
To simply change the permissions on existing Xen mappings. The existing destroy_xen_mappings() is altered to support a change the PTE permissions. A new destroy_xen_mappings() is introduced, as the special case of not passing _PAGE_PRESENT to modify_xen_mappings(). As cleanup (and an ideal funct