Re: [Xen-devel] [PATCH v7 2/8] cxenstored: add support for systemd active sockets

2015-08-06 Thread George Dunlap
On 08/05/2015 07:19 PM, Wei Liu wrote: > On Wed, Aug 05, 2015 at 06:24:37PM +0100, Wei Liu wrote: > [...] >>> >> >> Right. I misinterpreted sd_boot. >> >> You patch, however, has the undesirable effect that it fails to report >> error if xenstored is started by systemd but couldn't claim the >> soc

Re: [Xen-devel] [PATCH v7 2/8] cxenstored: add support for systemd active sockets

2015-08-06 Thread Ian Campbell
On Thu, 2015-08-06 at 11:56 +0100, Wei Liu wrote: > On Thu, Aug 06, 2015 at 11:48:15AM +0100, Ian Campbell wrote: > > On Thu, 2015-08-06 at 11:17 +0100, Wei Liu wrote: > > > > > > I don't think so. Though the doc is not clear on how we should use > > > those > > > APIs, I got my idea from > > >

Re: [Xen-devel] [PATCH v7 2/8] cxenstored: add support for systemd active sockets

2015-08-06 Thread Wei Liu
On Thu, Aug 06, 2015 at 11:48:15AM +0100, Ian Campbell wrote: > On Thu, 2015-08-06 at 11:17 +0100, Wei Liu wrote: > > > > I don't think so. Though the doc is not clear on how we should use those > > APIs, I got my idea from > > > > http://0pointer.de/public/cups-patch-core.txt > > > > which doe

Re: [Xen-devel] [PATCH v7 2/8] cxenstored: add support for systemd active sockets

2015-08-06 Thread Ian Campbell
On Thu, 2015-08-06 at 11:17 +0100, Wei Liu wrote: > > I don't think so. Though the doc is not clear on how we should use those > APIs, I got my idea from > > http://0pointer.de/public/cups-patch-core.txt > > which doesn't call sd_booted. OK, FM then: Acked-by: Ian Campbell As a future cleanu

Re: [Xen-devel] [PATCH v7 2/8] cxenstored: add support for systemd active sockets

2015-08-06 Thread Wei Liu
Sorry I missed some inline comments. On Thu, Aug 06, 2015 at 10:13:16AM +0100, Ian Campbell wrote: > > ---8<--- > > From a03eba6e258d8097b974366abb50b39af9e9abbf Mon Sep 17 00:00:00 2001 > > From: Wei Liu > > Date: Wed, 5 Aug 2015 19:02:34 +0100 > > Subject: [PATCH] cxenstored: fix systemd socket

Re: [Xen-devel] [PATCH v7 2/8] cxenstored: add support for systemd active sockets

2015-08-06 Thread Wei Liu
On Thu, Aug 06, 2015 at 10:29:59AM +0100, Ian Campbell wrote: > On Thu, 2015-08-06 at 10:20 +0100, Wei Liu wrote: > > On Thu, Aug 06, 2015 at 10:13:16AM +0100, Ian Campbell wrote: > > > On Wed, 2015-08-05 at 19:19 +0100, Wei Liu wrote: > > > > On Wed, Aug 05, 2015 at 06:24:37PM +0100, Wei Liu wrote

Re: [Xen-devel] [PATCH v7 2/8] cxenstored: add support for systemd active sockets

2015-08-06 Thread Ian Campbell
On Thu, 2015-08-06 at 10:20 +0100, Wei Liu wrote: > On Thu, Aug 06, 2015 at 10:13:16AM +0100, Ian Campbell wrote: > > On Wed, 2015-08-05 at 19:19 +0100, Wei Liu wrote: > > > On Wed, Aug 05, 2015 at 06:24:37PM +0100, Wei Liu wrote: > > > [...] > > > > > > > > > > > > > Right. I misinterpreted sd_b

Re: [Xen-devel] [PATCH v7 2/8] cxenstored: add support for systemd active sockets

2015-08-06 Thread Wei Liu
On Thu, Aug 06, 2015 at 10:13:16AM +0100, Ian Campbell wrote: > On Wed, 2015-08-05 at 19:19 +0100, Wei Liu wrote: > > On Wed, Aug 05, 2015 at 06:24:37PM +0100, Wei Liu wrote: > > [...] > > > > > > > > > > Right. I misinterpreted sd_boot. > > > > > > You patch, however, has the undesirable effect

Re: [Xen-devel] [PATCH v7 2/8] cxenstored: add support for systemd active sockets

2015-08-06 Thread Ian Campbell
On Wed, 2015-08-05 at 19:19 +0100, Wei Liu wrote: > On Wed, Aug 05, 2015 at 06:24:37PM +0100, Wei Liu wrote: > [...] > > > > > > > Right. I misinterpreted sd_boot. > > > > You patch, however, has the undesirable effect that it fails to report > > error if xenstored is started by systemd but coul

Re: [Xen-devel] [PATCH v7 2/8] cxenstored: add support for systemd active sockets

2015-08-05 Thread Wei Liu
On Wed, Aug 05, 2015 at 06:24:37PM +0100, Wei Liu wrote: [...] > > > > Right. I misinterpreted sd_boot. > > You patch, however, has the undesirable effect that it fails to report > error if xenstored is started by systemd but couldn't claim the > socket. I don't think this is the correct behavio

Re: [Xen-devel] [PATCH v7 2/8] cxenstored: add support for systemd active sockets

2015-08-05 Thread Wei Liu
On Wed, Aug 05, 2015 at 05:30:34PM +0100, George Dunlap wrote: > On Wed, Aug 5, 2015 at 2:17 PM, Wei Liu wrote: > > On Wed, Aug 05, 2015 at 11:56:44AM +0100, George Dunlap wrote: > >> On Wed, Aug 5, 2015 at 11:17 AM, Ian Campbell > >> wrote: > >> > On Wed, 2015-08-05 at 11:06 +0100, George Dunla

Re: [Xen-devel] [PATCH v7 2/8] cxenstored: add support for systemd active sockets

2015-08-05 Thread George Dunlap
On Wed, Aug 5, 2015 at 2:17 PM, Wei Liu wrote: > On Wed, Aug 05, 2015 at 11:56:44AM +0100, George Dunlap wrote: >> On Wed, Aug 5, 2015 at 11:17 AM, Ian Campbell >> wrote: >> > On Wed, 2015-08-05 at 11:06 +0100, George Dunlap wrote: >> >> On Fri, Jul 18, 2014 at 12:28 AM, Luis R. Rodriguez >> >>

Re: [Xen-devel] [PATCH v7 2/8] cxenstored: add support for systemd active sockets

2015-08-05 Thread Wei Liu
On Wed, Aug 05, 2015 at 11:56:44AM +0100, George Dunlap wrote: > On Wed, Aug 5, 2015 at 11:17 AM, Ian Campbell wrote: > > On Wed, 2015-08-05 at 11:06 +0100, George Dunlap wrote: > >> On Fri, Jul 18, 2014 at 12:28 AM, Luis R. Rodriguez > >> wrote: > >> > From: "Luis R. Rodriguez" > >> > > >> > Th

Re: [Xen-devel] [PATCH v7 2/8] cxenstored: add support for systemd active sockets

2015-08-05 Thread Ian Campbell
On Wed, 2015-08-05 at 12:21 +0100, George Dunlap wrote: > On Wed, Aug 5, 2015 at 12:11 PM, Ian Campbell > wrote: > > On Wed, 2015-08-05 at 11:56 +0100, George Dunlap wrote: > > > On Wed, Aug 5, 2015 at 11:17 AM, Ian Campbell < > > > ian.campb...@citrix.com> > > > wrote: > > > > On Wed, 2015-08-05

Re: [Xen-devel] [PATCH v7 2/8] cxenstored: add support for systemd active sockets

2015-08-05 Thread George Dunlap
On Wed, Aug 5, 2015 at 12:11 PM, Ian Campbell wrote: > On Wed, 2015-08-05 at 11:56 +0100, George Dunlap wrote: >> On Wed, Aug 5, 2015 at 11:17 AM, Ian Campbell >> wrote: >> > On Wed, 2015-08-05 at 11:06 +0100, George Dunlap wrote: >> > > On Fri, Jul 18, 2014 at 12:28 AM, Luis R. Rodriguez >> > >

Re: [Xen-devel] [PATCH v7 2/8] cxenstored: add support for systemd active sockets

2015-08-05 Thread Ian Campbell
On Wed, 2015-08-05 at 12:11 +0100, Ian Campbell wrote: > > I'm a bit surprised that chkconfig doesn't just to the right thing. It's > possible that the fact that our initscript and our systemd unitfiles do not > share the same names has defeated its heuristics. Perhaps as well as fixing xenstored

Re: [Xen-devel] [PATCH v7 2/8] cxenstored: add support for systemd active sockets

2015-08-05 Thread Ian Campbell
On Wed, 2015-08-05 at 11:56 +0100, George Dunlap wrote: > On Wed, Aug 5, 2015 at 11:17 AM, Ian Campbell > wrote: > > On Wed, 2015-08-05 at 11:06 +0100, George Dunlap wrote: > > > On Fri, Jul 18, 2014 at 12:28 AM, Luis R. Rodriguez > > > wrote: > > > > From: "Luis R. Rodriguez" > > > > > > > >

Re: [Xen-devel] [PATCH v7 2/8] cxenstored: add support for systemd active sockets

2015-08-05 Thread George Dunlap
On Wed, Aug 5, 2015 at 11:17 AM, Ian Campbell wrote: > On Wed, 2015-08-05 at 11:06 +0100, George Dunlap wrote: >> On Fri, Jul 18, 2014 at 12:28 AM, Luis R. Rodriguez >> wrote: >> > From: "Luis R. Rodriguez" >> > >> > This adds systemd socket activation support for the C xenstored. >> > Active so

Re: [Xen-devel] [PATCH v7 2/8] cxenstored: add support for systemd active sockets

2015-08-05 Thread Ian Campbell
On Wed, 2015-08-05 at 11:06 +0100, George Dunlap wrote: > On Fri, Jul 18, 2014 at 12:28 AM, Luis R. Rodriguez > wrote: > > From: "Luis R. Rodriguez" > > > > This adds systemd socket activation support for the C xenstored. > > Active sockets enable xenstored to be loaded only if required by a >

Re: [Xen-devel] [PATCH v7 2/8] cxenstored: add support for systemd active sockets

2015-08-05 Thread George Dunlap
On Fri, Jul 18, 2014 at 12:28 AM, Luis R. Rodriguez wrote: > From: "Luis R. Rodriguez" > > This adds systemd socket activation support for the C xenstored. > Active sockets enable xenstored to be loaded only if required by a system > onto which Xen is installed on. Socket activation is handled by