Re: [Xen-devel] [PATCH v7 2/5] x86/pvclock: add setter for pvclock_pvti_cpu0_va

2017-11-08 Thread Thomas Gleixner
On Wed, 8 Nov 2017, Joao Martins wrote: > On 11/08/2017 11:06 AM, Thomas Gleixner wrote: > > The only nit-pick I have are the convoluted function names: > > > > pvclock_set_pvti_cpu0_va() pvclock_pvti_cpu0_va() > > > > What on earth does that mean? > > > Those two functions respectively set a

Re: [Xen-devel] [PATCH v7 2/5] x86/pvclock: add setter for pvclock_pvti_cpu0_va

2017-11-08 Thread Joao Martins
On 11/08/2017 11:06 AM, Thomas Gleixner wrote: > On Tue, 7 Nov 2017, Joao Martins wrote: >> On 11/06/2017 04:09 PM, Paolo Bonzini wrote: >>> On 19/10/2017 15:39, Joao Martins wrote: Right now there is only a pvclock_pvti_cpu0_va() which is defined on kvmclock since: commit dac16

Re: [Xen-devel] [PATCH v7 2/5] x86/pvclock: add setter for pvclock_pvti_cpu0_va

2017-11-08 Thread Thomas Gleixner
On Tue, 7 Nov 2017, Joao Martins wrote: > On 11/06/2017 04:09 PM, Paolo Bonzini wrote: > > On 19/10/2017 15:39, Joao Martins wrote: > >> Right now there is only a pvclock_pvti_cpu0_va() which is defined > >> on kvmclock since: > >> > >> commit dac16fba6fc5 > >> ("x86/vdso: Get pvclock data from the

Re: [Xen-devel] [PATCH v7 2/5] x86/pvclock: add setter for pvclock_pvti_cpu0_va

2017-11-07 Thread Joao Martins
On 11/06/2017 04:09 PM, Paolo Bonzini wrote: > On 19/10/2017 15:39, Joao Martins wrote: >> Right now there is only a pvclock_pvti_cpu0_va() which is defined >> on kvmclock since: >> >> commit dac16fba6fc5 >> ("x86/vdso: Get pvclock data from the vvar VMA instead of the fixmap") >> >> The only user

Re: [Xen-devel] [PATCH v7 2/5] x86/pvclock: add setter for pvclock_pvti_cpu0_va

2017-11-06 Thread Paolo Bonzini
On 19/10/2017 15:39, Joao Martins wrote: > Right now there is only a pvclock_pvti_cpu0_va() which is defined > on kvmclock since: > > commit dac16fba6fc5 > ("x86/vdso: Get pvclock data from the vvar VMA instead of the fixmap") > > The only user of this interface so far is kvm. This commit adds a

[Xen-devel] [PATCH v7 2/5] x86/pvclock: add setter for pvclock_pvti_cpu0_va

2017-10-19 Thread Joao Martins
Right now there is only a pvclock_pvti_cpu0_va() which is defined on kvmclock since: commit dac16fba6fc5 ("x86/vdso: Get pvclock data from the vvar VMA instead of the fixmap") The only user of this interface so far is kvm. This commit adds a setter function for the pvti page and moves pvclock_pvt