Re: [Xen-devel] [PATCH v7 2/5] sysctl: Add sysctl interface for querying PCI topology

2015-05-01 Thread Ian Campbell
On Fri, 2015-05-01 at 11:20 -0400, Boris Ostrovsky wrote: > On 05/01/2015 09:56 AM, Ian Campbell wrote: > > On Fri, 2015-04-24 at 13:42 -0400, Boris Ostrovsky wrote: > >> On 04/24/2015 10:09 AM, Boris Ostrovsky wrote: > >>> On 04/24/2015 03:19 AM, Jan Beulich wrote: > >>> On 24.04.15 at 00:20,

Re: [Xen-devel] [PATCH v7 2/5] sysctl: Add sysctl interface for querying PCI topology

2015-05-01 Thread Boris Ostrovsky
On 05/01/2015 09:56 AM, Ian Campbell wrote: On Fri, 2015-04-24 at 13:42 -0400, Boris Ostrovsky wrote: On 04/24/2015 10:09 AM, Boris Ostrovsky wrote: On 04/24/2015 03:19 AM, Jan Beulich wrote: On 24.04.15 at 00:20, wrote: On 04/21/2015 03:01 AM, Jan Beulich wrote: + ((++dev_c

Re: [Xen-devel] [PATCH v7 2/5] sysctl: Add sysctl interface for querying PCI topology

2015-05-01 Thread Ian Campbell
On Fri, 2015-04-24 at 13:42 -0400, Boris Ostrovsky wrote: > On 04/24/2015 10:09 AM, Boris Ostrovsky wrote: > > > > On 04/24/2015 03:19 AM, Jan Beulich wrote: > > On 24.04.15 at 00:20, wrote: > >>> On 04/21/2015 03:01 AM, Jan Beulich wrote: > > + ((++dev_cnt > 0x3f) && hyper

Re: [Xen-devel] [PATCH v7 2/5] sysctl: Add sysctl interface for querying PCI topology

2015-04-24 Thread Boris Ostrovsky
On 04/24/2015 10:09 AM, Boris Ostrovsky wrote: On 04/24/2015 03:19 AM, Jan Beulich wrote: On 24.04.15 at 00:20, wrote: On 04/21/2015 03:01 AM, Jan Beulich wrote: + ((++dev_cnt > 0x3f) && hypercall_preempt_check()) ) +break; +} + +if ( (!ret ||

Re: [Xen-devel] [PATCH v7 2/5] sysctl: Add sysctl interface for querying PCI topology

2015-04-24 Thread Boris Ostrovsky
On 04/24/2015 03:19 AM, Jan Beulich wrote: On 24.04.15 at 00:20, wrote: On 04/21/2015 03:01 AM, Jan Beulich wrote: + ((++dev_cnt > 0x3f) && hypercall_preempt_check()) ) +break; +} + +if ( (!ret || (ret == -ENODEV)) && + __copy_field_

Re: [Xen-devel] [PATCH v7 2/5] sysctl: Add sysctl interface for querying PCI topology

2015-04-24 Thread Jan Beulich
>>> On 24.04.15 at 00:20, wrote: > On 04/21/2015 03:01 AM, Jan Beulich wrote: >> >>> + ((++dev_cnt > 0x3f) && hypercall_preempt_check()) ) >>> +break; >>> +} >>> + >>> +if ( (!ret || (ret == -ENODEV)) && >>> + __copy_field_to_guest(u_sysc

Re: [Xen-devel] [PATCH v7 2/5] sysctl: Add sysctl interface for querying PCI topology

2015-04-23 Thread Boris Ostrovsky
On 04/21/2015 03:01 AM, Jan Beulich wrote: + ((++dev_cnt > 0x3f) && hypercall_preempt_check()) ) +break; +} + +if ( (!ret || (ret == -ENODEV)) && + __copy_field_to_guest(u_sysctl, op, u.pcitopoinfo.first_dev) ) +ret = -EFAU

Re: [Xen-devel] [PATCH v7 2/5] sysctl: Add sysctl interface for querying PCI topology

2015-04-21 Thread Andrew Cooper
On 21/04/15 14:13, Boris Ostrovsky wrote: > > On 04/21/2015 09:14 AM, Andrew Cooper wrote: >> On 21/04/15 13:56, Boris Ostrovsky wrote: >>> On 04/21/2015 03:01 AM, Jan Beulich wrote: >>> --- a/docs/misc/xsm-flask.txt >>> +++ b/docs/misc/xsm-flask.txt >>> @@ -121,6 +121,7 @@ __HYPERVISOR

Re: [Xen-devel] [PATCH v7 2/5] sysctl: Add sysctl interface for querying PCI topology

2015-04-21 Thread Boris Ostrovsky
On 04/21/2015 09:14 AM, Andrew Cooper wrote: On 21/04/15 13:56, Boris Ostrovsky wrote: On 04/21/2015 03:01 AM, Jan Beulich wrote: --- a/docs/misc/xsm-flask.txt +++ b/docs/misc/xsm-flask.txt @@ -121,6 +121,7 @@ __HYPERVISOR_sysctl (xen/include/public/sysctl.h) * XEN_SYSCTL_cpupool_op *

Re: [Xen-devel] [PATCH v7 2/5] sysctl: Add sysctl interface for querying PCI topology

2015-04-21 Thread Jan Beulich
>>> On 21.04.15 at 14:56, wrote: > On 04/21/2015 03:01 AM, Jan Beulich wrote: > On 17.04.15 at 18:59, wrote: >>> Changes in v7: >>> * Break from the loop when -ENODEV is encountered >> This seems pretty inefficient for the caller. Returning a "bad" >> identifier other than XEN_INVALID_NODE_I

Re: [Xen-devel] [PATCH v7 2/5] sysctl: Add sysctl interface for querying PCI topology

2015-04-21 Thread Andrew Cooper
On 21/04/15 13:56, Boris Ostrovsky wrote: > > On 04/21/2015 03:01 AM, Jan Beulich wrote: > On 17.04.15 at 18:59, wrote: >>> Changes in v7: >>> * Break from the loop when -ENODEV is encountered >> This seems pretty inefficient for the caller. Returning a "bad" >> identifier other than XEN_INVAL

Re: [Xen-devel] [PATCH v7 2/5] sysctl: Add sysctl interface for querying PCI topology

2015-04-21 Thread Boris Ostrovsky
On 04/21/2015 03:01 AM, Jan Beulich wrote: On 17.04.15 at 18:59, wrote: Changes in v7: * Break from the loop when -ENODEV is encountered This seems pretty inefficient for the caller. Returning a "bad" identifier other than XEN_INVALID_NODE_ID would seem better to me. That would mean that th

Re: [Xen-devel] [PATCH v7 2/5] sysctl: Add sysctl interface for querying PCI topology

2015-04-21 Thread Jan Beulich
>>> On 17.04.15 at 18:59, wrote: > Changes in v7: > * Break from the loop when -ENODEV is encountered This seems pretty inefficient for the caller. Returning a "bad" identifier other than XEN_INVALID_NODE_ID would seem better to me. > --- a/docs/misc/xsm-flask.txt > +++ b/docs/misc/xsm-flask.txt

Re: [Xen-devel] [PATCH v7 2/5] sysctl: Add sysctl interface for querying PCI topology

2015-04-17 Thread Andrew Cooper
On 17/04/15 17:59, Boris Ostrovsky wrote: > Signed-off-by: Boris Ostrovsky > Acked-by: Daniel De Graaf Reviewed-by: Andrew Cooper ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

[Xen-devel] [PATCH v7 2/5] sysctl: Add sysctl interface for querying PCI topology

2015-04-17 Thread Boris Ostrovsky
Signed-off-by: Boris Ostrovsky Acked-by: Daniel De Graaf --- Changes in v7: * Break from the loop when -ENODEV is encountered docs/misc/xsm-flask.txt |1 + xen/common/sysctl.c | 59 +++ xen/include/public/sysctl.h | 30