Re: [Xen-devel] [PATCH v7 1/2] OSSTEST: introduce a raisin build test

2015-07-20 Thread Ian Jackson
Ian Campbell writes ("Re: [PATCH v7 1/2] OSSTEST: introduce a raisin build test"): > Unfortunately ts-xen-build-prep will not have access to the repo, since > it won't be cloned. Also when reusing a host (which happens for builds) > I think this step is skipped (Ian J: can you confirm or deny that

Re: [Xen-devel] [PATCH v7 1/2] OSSTEST: introduce a raisin build test

2015-07-20 Thread Ian Campbell
Ian -- various questions for you here. On Mon, 2015-07-20 at 13:56 +0100, Stefano Stabellini wrote: > On Thu, 9 Jul 2015, Ian Campbell wrote: > > On Mon, 2015-06-22 at 16:16 +0100, Stefano Stabellini wrote: > > > Signed-off-by: Stefano Stabellini > > [...] > > I didn't do a good job with the com

Re: [Xen-devel] [PATCH v7 1/2] OSSTEST: introduce a raisin build test

2015-07-20 Thread Stefano Stabellini
On Thu, 9 Jul 2015, Ian Campbell wrote: > On Mon, 2015-06-22 at 16:16 +0100, Stefano Stabellini wrote: > > Signed-off-by: Stefano Stabellini > > In general I'm very suspicious of a 200 line patch with _no_ commit > message at all. > > What about the details of the stuff around overriding the ver

Re: [Xen-devel] [PATCH v7 1/2] OSSTEST: introduce a raisin build test

2015-07-09 Thread Ian Campbell
On Mon, 2015-06-22 at 16:16 +0100, Stefano Stabellini wrote: > Signed-off-by: Stefano Stabellini In general I'm very suspicious of a 200 line patch with _no_ commit message at all. What about the details of the stuff around overriding the versions iff tree and revision are set etc and why that m

[Xen-devel] [PATCH v7 1/2] OSSTEST: introduce a raisin build test

2015-06-22 Thread Stefano Stabellini
Signed-off-by: Stefano Stabellini --- Changes in v7: - update raisin git url after http://marc.info/?l=xen-devel&m=143472251602803 Changes in v6: - move divide to Osstest/BuildSupport.pm and rename it to divide_xen_build; use divide_xen_build in ts-raisin-build and ts-xen-build. Changes in v5: