Re: [Xen-devel] [PATCH v7]xen: sched: convert RTDS from time to event driven model

2016-03-10 Thread Meng Xu
[My bad, Dario, I somehow only sent to you my reply... I'm resending to everyone.] On Thu, Mar 10, 2016 at 6:53 PM, Dario Faggioli wrote: > On Thu, 2016-03-10 at 13:08 -0500, Meng Xu wrote: >> On Thu, Mar 10, 2016 at 11:43 AM, Dario Faggioli >> wrote: >> > >> I think the pseudo-code makes sense.

Re: [Xen-devel] [PATCH v7]xen: sched: convert RTDS from time to event driven model

2016-03-10 Thread Dario Faggioli
On Thu, 2016-03-10 at 13:08 -0500, Meng Xu wrote: > On Thu, Mar 10, 2016 at 11:43 AM, Dario Faggioli > wrote: > >  > I think the pseudo-code makes sense. I just need to add some more > logic into it to make it complete. It forgets to handle the runq. > You mean... > > > > > >   ... > >   LIST_H

Re: [Xen-devel] [PATCH v7]xen: sched: convert RTDS from time to event driven model

2016-03-10 Thread Meng Xu
On Thu, Mar 10, 2016 at 11:43 AM, Dario Faggioli wrote: > On Thu, 2016-03-10 at 10:28 -0500, Meng Xu wrote: >> On Thu, Mar 10, 2016 at 5:38 AM, Dario Faggioli >> wrote: >> > >> > I don't think we really need to count anything. In fact, what I had >> > in >> > mind and tried to put down in pseudoc

Re: [Xen-devel] [PATCH v7]xen: sched: convert RTDS from time to event driven model

2016-03-10 Thread Dario Faggioli
On Thu, 2016-03-10 at 10:28 -0500, Meng Xu wrote: > On Thu, Mar 10, 2016 at 5:38 AM, Dario Faggioli > wrote: > > > > I don't think we really need to count anything. In fact, what I had > > in > > mind and tried to put down in pseudocode is that we traverse the > > list > > of replenishment events

Re: [Xen-devel] [PATCH v7]xen: sched: convert RTDS from time to event driven model

2016-03-10 Thread Meng Xu
On Thu, Mar 10, 2016 at 5:38 AM, Dario Faggioli wrote: > On Wed, 2016-03-09 at 23:00 -0500, Meng Xu wrote: >> On Wed, Mar 9, 2016 at 10:46 AM, Dario Faggioli >> wrote: >> > >> > Basically, by doing all the replenishments (which includes updating >> > all >> > the deadlines) upfront, we should be

Re: [Xen-devel] [PATCH v7]xen: sched: convert RTDS from time to event driven model

2016-03-10 Thread Dario Faggioli
On Wed, 2016-03-09 at 23:00 -0500, Meng Xu wrote: > On Wed, Mar 9, 2016 at 10:46 AM, Dario Faggioli > wrote: > >  > > Basically, by doing all the replenishments (which includes updating > > all > > the deadlines) upfront, we should be able to prevent the above > > situation. > > > > So, again, th

Re: [Xen-devel] [PATCH v7]xen: sched: convert RTDS from time to event driven model

2016-03-09 Thread Meng Xu
On Wed, Mar 9, 2016 at 10:46 AM, Dario Faggioli wrote: > On Tue, 2016-03-08 at 23:33 -0500, Meng Xu wrote: >> I didn't mark out all repeated style issues. I think you can correct >> all of the style issues, such as the spaces in the code, in the next >> version. >> > Yes, please. At v7, style issu

Re: [Xen-devel] [PATCH v7]xen: sched: convert RTDS from time to event driven model

2016-03-09 Thread Dario Faggioli
On Tue, 2016-03-08 at 23:33 -0500, Meng Xu wrote: > I didn't mark out all repeated style issues. I think you can correct > all of the style issues, such as the spaces in the code, in the next > version. > Yes, please. At v7, style issues shouldn't definitely be there any longer. Have another look

Re: [Xen-devel] [PATCH v7]xen: sched: convert RTDS from time to event driven model

2016-03-08 Thread Meng Xu
Hi Tianyang, Thank you very much for this version of patch. It is in a really good state, IMHO, although it does have a suspiciuous logic error inside, which can be corrected easily. I didn't mark out all repeated style issues. I think you can correct all of the style issues, such as the spaces i

[Xen-devel] [PATCH v7]xen: sched: convert RTDS from time to event driven model

2016-03-04 Thread Tianyang Chen
Budget replenishment and enforcement are separated by adding a replenishment timer, which fires at the next most imminent release time of all runnable vcpus. A replenishment queue has been added to keep track of all replenishment events. The following functions have major changes to manage the re