On 06/09/2015 05:10 PM, Andrew Cooper wrote:
On 09/06/15 10:09, Yang Hongyang wrote:
Shouldn't get_dirty_pfn be mandatory for COLO streams (even if it
is a
noop to start with) ?
It should be mandatory, it shouldn't be noop under COLO. perhaps we
should
add sanity check at the beginnin
On 09/06/15 10:09, Yang Hongyang wrote:
>
>
>>
>>>
>> Shouldn't get_dirty_pfn be mandatory for COLO streams (even if it
>> is a
>> noop to start with) ?
>
> It should be mandatory, it shouldn't be noop under COLO. perhaps we
> should
> add sanity check at the beginning.
On 06/09/2015 04:51 PM, Andrew Cooper wrote:
On 09/06/15 09:45, Yang Hongyang wrote:
Even if there are no dirty pages on secondary, pfn_list shouldn't be
NULL, it's just that pfn_list[0] will be 0. if pfn_list is NULL,
there might be unexpected error happened.
get_dirty_pfn() should be dec
On 09/06/15 09:45, Yang Hongyang wrote:
>
>>> Even if there are no dirty pages on secondary, pfn_list shouldn't be
>>> NULL, it's just that pfn_list[0] will be 0. if pfn_list is NULL,
>>> there might be unexpected error happened.
>>
>> get_dirty_pfn() should be declared alongside a
>>
>> struct pfn
On 06/09/2015 03:20 PM, Andrew Cooper wrote:
On 09/06/2015 04:15, Yang Hongyang wrote:
On 06/08/2015 09:04 PM, Andrew Cooper wrote:
On 08/06/15 04:45, Yang Hongyang wrote:
call callbacks->get_dirty_pfn() after suspend primary vm to
get dirty pages on secondary vm, and send pages both dirty
On 09/06/2015 04:15, Yang Hongyang wrote:
>
>
> On 06/08/2015 09:04 PM, Andrew Cooper wrote:
>> On 08/06/15 04:45, Yang Hongyang wrote:
>>> call callbacks->get_dirty_pfn() after suspend primary vm to
>>> get dirty pages on secondary vm, and send pages both dirty on
>>> primary/secondary to secondar
On 06/08/2015 09:04 PM, Andrew Cooper wrote:
On 08/06/15 04:45, Yang Hongyang wrote:
call callbacks->get_dirty_pfn() after suspend primary vm to
get dirty pages on secondary vm, and send pages both dirty on
primary/secondary to secondary.
Signed-off-by: Yang Hongyang
Signed-off-by: Wen Congy
On 06/08/2015 09:04 PM, Andrew Cooper wrote:
On 08/06/15 04:45, Yang Hongyang wrote:
call callbacks->get_dirty_pfn() after suspend primary vm to
get dirty pages on secondary vm, and send pages both dirty on
primary/secondary to secondary.
Signed-off-by: Yang Hongyang
Signed-off-by: Wen Congy
On 08/06/15 04:45, Yang Hongyang wrote:
> call callbacks->get_dirty_pfn() after suspend primary vm to
> get dirty pages on secondary vm, and send pages both dirty on
> primary/secondary to secondary.
>
> Signed-off-by: Yang Hongyang
> Signed-off-by: Wen Congyang
> CC: Andrew Cooper
> ---
> tool
call callbacks->get_dirty_pfn() after suspend primary vm to
get dirty pages on secondary vm, and send pages both dirty on
primary/secondary to secondary.
Signed-off-by: Yang Hongyang
Signed-off-by: Wen Congyang
CC: Andrew Cooper
---
tools/libxc/xc_sr_save.c | 49 +++
10 matches
Mail list logo
