Re: [Xen-devel] [PATCH v6 2/4] xen: introduce a C99 headers check

2017-03-30 Thread Stefano Stabellini
On Thu, 30 Mar 2017, Jan Beulich wrote: > >>> On 30.03.17 at 00:18, wrote: > > @@ -104,16 +105,22 @@ headers.chk: $(PUBLIC_ANSI_HEADERS) Makefile > > done >$@.new > > mv $@.new $@ > > > > +headers99.chk: $(PUBLIC_C99_HEADERS) Makefile > > + rm -f $@.new $@ > > Why also $@? > > > +

Re: [Xen-devel] [PATCH v6 2/4] xen: introduce a C99 headers check

2017-03-30 Thread Jan Beulich
>>> On 30.03.17 at 00:18, wrote: > @@ -104,16 +105,22 @@ headers.chk: $(PUBLIC_ANSI_HEADERS) Makefile > done >$@.new > mv $@.new $@ > > +headers99.chk: $(PUBLIC_C99_HEADERS) Makefile > + rm -f $@.new $@ Why also $@? > + $(foreach i, $(filter %.h,$^), $(CC) -x c -std=c99 -Wa

[Xen-devel] [PATCH v6 2/4] xen: introduce a C99 headers check

2017-03-29 Thread Stefano Stabellini
Introduce a C99 headers check, for non-ANSI compliant headers: 9pfs.h and pvcalls.h. In addition to the usual -include stdint.h, also add -include string.h to the C99 check to get the declaration of memcpy and size_t. For the same reason, also add -include cstring to the C++ check when necessary.