Re: [Xen-devel] [PATCH v6 2/4] x86/ldt: Make modify_ldt synchronous

2015-07-30 Thread Andy Lutomirski
On Thu, Jul 30, 2015 at 3:50 PM, Andrew Cooper wrote: > On 30/07/2015 22:31, Andy Lutomirski wrote: >> Note to -stable maintainers: by itself, this patch makes a >> pre-existing Xen bug much easier to trigger; on a 32-bit Xen guest, >> the new ldt_gdt selftest is likely to OOPS. Even without this

Re: [Xen-devel] [PATCH v6 2/4] x86/ldt: Make modify_ldt synchronous

2015-07-30 Thread Andrew Cooper
On 30/07/2015 22:31, Andy Lutomirski wrote: > Note to -stable maintainers: by itself, this patch makes a > pre-existing Xen bug much easier to trigger; on a 32-bit Xen guest, > the new ldt_gdt selftest is likely to OOPS. Even without this > patch, the test can OOPS, but it's much less likely to ha

[Xen-devel] [PATCH v6 2/4] x86/ldt: Make modify_ldt synchronous

2015-07-30 Thread Andy Lutomirski
modify_ldt has questionable locking and does not synchronize threads. Improve it: redesign the locking and synchronize all threads' LDTs using an IPI on all modifications. This will dramatically slow down modify_ldt in multithreaded programs, but there shouldn't be any multithreaded programs that