Re: [Xen-devel] [PATCH v6 16/16] libxl/arm: Add the size of ACPI tables to maxmem

2016-09-28 Thread Julien Grall
Hi, On 28/09/2016 06:17, Wei Liu wrote: On Wed, Sep 28, 2016 at 06:11:53AM -0700, Shannon Zhao wrote: libxl__get_acpi_size(gc, info, gic_version /* not build_state anymore */) /* also fix up libxl__estimate_madt_size */ /* this is the function called when constructing the domain etc, o

Re: [Xen-devel] [PATCH v6 16/16] libxl/arm: Add the size of ACPI tables to maxmem

2016-09-28 Thread Wei Liu
On Wed, Sep 28, 2016 at 06:11:53AM -0700, Shannon Zhao wrote: > > > On 2016/9/28 3:00, Wei Liu wrote: > >On Tue, Sep 27, 2016 at 11:43:38AM -0700, Shannon Zhao wrote: > >> > >> > >>On 2016/9/27 9:35, Wei Liu wrote: > >>>On Tue, Sep 27, 2016 at 09:01:00AM -0700, Shannon Zhao wrote: > > >

Re: [Xen-devel] [PATCH v6 16/16] libxl/arm: Add the size of ACPI tables to maxmem

2016-09-28 Thread Shannon Zhao
On 2016/9/28 3:00, Wei Liu wrote: On Tue, Sep 27, 2016 at 11:43:38AM -0700, Shannon Zhao wrote: On 2016/9/27 9:35, Wei Liu wrote: On Tue, Sep 27, 2016 at 09:01:00AM -0700, Shannon Zhao wrote: On 2016/9/27 2:41, Wei Liu wrote: On Mon, Sep 26, 2016 at 02:54:55PM -0700, Shannon Zhao wrote:

Re: [Xen-devel] [PATCH v6 16/16] libxl/arm: Add the size of ACPI tables to maxmem

2016-09-28 Thread Wei Liu
On Tue, Sep 27, 2016 at 11:43:38AM -0700, Shannon Zhao wrote: > > > On 2016/9/27 9:35, Wei Liu wrote: > >On Tue, Sep 27, 2016 at 09:01:00AM -0700, Shannon Zhao wrote: > >> > >> > >>On 2016/9/27 2:41, Wei Liu wrote: > >>>On Mon, Sep 26, 2016 at 02:54:55PM -0700, Shannon Zhao wrote: > > >

Re: [Xen-devel] [PATCH v6 16/16] libxl/arm: Add the size of ACPI tables to maxmem

2016-09-27 Thread Shannon Zhao
On 2016/9/27 9:35, Wei Liu wrote: On Tue, Sep 27, 2016 at 09:01:00AM -0700, Shannon Zhao wrote: On 2016/9/27 2:41, Wei Liu wrote: On Mon, Sep 26, 2016 at 02:54:55PM -0700, Shannon Zhao wrote: On 2016/9/22 7:10, Wei Liu wrote: diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.

Re: [Xen-devel] [PATCH v6 16/16] libxl/arm: Add the size of ACPI tables to maxmem

2016-09-27 Thread Wei Liu
On Tue, Sep 27, 2016 at 09:01:00AM -0700, Shannon Zhao wrote: > > > On 2016/9/27 2:41, Wei Liu wrote: > >On Mon, Sep 26, 2016 at 02:54:55PM -0700, Shannon Zhao wrote: > >> > >> > >>On 2016/9/22 7:10, Wei Liu wrote: > diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c > >index

Re: [Xen-devel] [PATCH v6 16/16] libxl/arm: Add the size of ACPI tables to maxmem

2016-09-27 Thread Shannon Zhao
On 2016/9/27 2:41, Wei Liu wrote: On Mon, Sep 26, 2016 at 02:54:55PM -0700, Shannon Zhao wrote: On 2016/9/22 7:10, Wei Liu wrote: diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c index 2924629..118beab 100644 --- a/tools/libxl/libxl_dom.c +++ b/tools/libxl/libxl_dom.c @@ -408

Re: [Xen-devel] [PATCH v6 16/16] libxl/arm: Add the size of ACPI tables to maxmem

2016-09-27 Thread Wei Liu
On Mon, Sep 26, 2016 at 02:54:55PM -0700, Shannon Zhao wrote: > > > On 2016/9/22 7:10, Wei Liu wrote: > >>diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c > >>> index 2924629..118beab 100644 > >>> --- a/tools/libxl/libxl_dom.c > >>> +++ b/tools/libxl/libxl_dom.c > >>> @@ -408,8 +408

Re: [Xen-devel] [PATCH v6 16/16] libxl/arm: Add the size of ACPI tables to maxmem

2016-09-27 Thread Wei Liu
On Mon, Sep 26, 2016 at 11:30:53AM -0700, Shannon Zhao wrote: > > > On 2016/9/26 2:05, Wei Liu wrote: > >On Mon, Sep 26, 2016 at 03:08:43PM +0800, Shannon Zhao wrote: > >>> > >>> > >>> On 2016/9/22 22:32, Wei Liu wrote: > >FAOD: > > > >I think all the issues I found so far in this

Re: [Xen-devel] [PATCH v6 16/16] libxl/arm: Add the size of ACPI tables to maxmem

2016-09-26 Thread Shannon Zhao
On 2016/9/22 7:10, Wei Liu wrote: diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c > index 2924629..118beab 100644 > --- a/tools/libxl/libxl_dom.c > +++ b/tools/libxl/libxl_dom.c > @@ -408,8 +408,15 @@ int libxl__build_pre(libxl__gc *gc, uint32_t domid, > } > } > > +

Re: [Xen-devel] [PATCH v6 16/16] libxl/arm: Add the size of ACPI tables to maxmem

2016-09-26 Thread Shannon Zhao
On 2016/9/26 2:05, Wei Liu wrote: On Mon, Sep 26, 2016 at 03:08:43PM +0800, Shannon Zhao wrote: > > > On 2016/9/22 22:32, Wei Liu wrote: > >FAOD: > > > >I think all the issues I found so far in this patch and other patch(es) > >are mostly cosmetic. I would be happy to accept incremental patch

Re: [Xen-devel] [PATCH v6 16/16] libxl/arm: Add the size of ACPI tables to maxmem

2016-09-26 Thread Wei Liu
On Mon, Sep 26, 2016 at 03:08:43PM +0800, Shannon Zhao wrote: > > > On 2016/9/22 22:32, Wei Liu wrote: > >FAOD: > > > >I think all the issues I found so far in this patch and other patch(es) > >are mostly cosmetic. I would be happy to accept incremental patches on > >top of this series to make th

Re: [Xen-devel] [PATCH v6 16/16] libxl/arm: Add the size of ACPI tables to maxmem

2016-09-26 Thread Shannon Zhao
On 2016/9/22 22:32, Wei Liu wrote: FAOD: I think all the issues I found so far in this patch and other patch(es) are mostly cosmetic. I would be happy to accept incremental patches on top of this series to make those changes. Ok, thanks for your review. No need to resend just yet unless th

Re: [Xen-devel] [PATCH v6 16/16] libxl/arm: Add the size of ACPI tables to maxmem

2016-09-22 Thread Wei Liu
On Thu, Sep 22, 2016 at 03:10:46PM +0100, Wei Liu wrote: > On Thu, Sep 22, 2016 at 08:52:33PM +0800, z00226004 wrote: > > From: Shannon Zhao > > > > Here it adds the ACPI tables size to set the target maxmem to avoid > > providing less available memory for guest. > > > > Signed-off-by: Shannon Z

Re: [Xen-devel] [PATCH v6 16/16] libxl/arm: Add the size of ACPI tables to maxmem

2016-09-22 Thread Wei Liu
On Thu, Sep 22, 2016 at 08:52:33PM +0800, z00226004 wrote: > From: Shannon Zhao > > Here it adds the ACPI tables size to set the target maxmem to avoid > providing less available memory for guest. > > Signed-off-by: Shannon Zhao > --- > tools/libxl/libxl_arch.h| 4 > tools/libxl/

[Xen-devel] [PATCH v6 16/16] libxl/arm: Add the size of ACPI tables to maxmem

2016-09-22 Thread z00226004
From: Shannon Zhao Here it adds the ACPI tables size to set the target maxmem to avoid providing less available memory for guest. Signed-off-by: Shannon Zhao --- tools/libxl/libxl_arch.h| 4 tools/libxl/libxl_arm.c | 16 tools/libxl/libxl_arm.h |