On 07/04/17 23:09, Stefano Stabellini wrote:
> On Fri, 7 Apr 2017, Stefano Stabellini wrote:
>> On Fri, 7 Apr 2017, Julien Grall wrote:
>>> Hi Andre,
>>>
>>> On 04/07/2017 09:46 PM, André Przywara wrote:
On 07/04/17 20:07, Stefano Stabellini wrote:
> On Fri, 7 Apr 2017, Andre Przywara wrot
On Fri, 7 Apr 2017, Stefano Stabellini wrote:
> On Fri, 7 Apr 2017, Julien Grall wrote:
> > Hi Andre,
> >
> > On 04/07/2017 09:46 PM, André Przywara wrote:
> > > On 07/04/17 20:07, Stefano Stabellini wrote:
> > > > On Fri, 7 Apr 2017, Andre Przywara wrote:
> > > > > For LPIs the struct pending_irq
On Fri, 7 Apr 2017, Julien Grall wrote:
> Hi Andre,
>
> On 04/07/2017 09:46 PM, André Przywara wrote:
> > On 07/04/17 20:07, Stefano Stabellini wrote:
> > > On Fri, 7 Apr 2017, Andre Przywara wrote:
> > > > For LPIs the struct pending_irq's are somewhat dynamically allocated and
> > > > the pointe
Hi Andre,
On 04/07/2017 09:46 PM, André Przywara wrote:
On 07/04/17 20:07, Stefano Stabellini wrote:
On Fri, 7 Apr 2017, Andre Przywara wrote:
For LPIs the struct pending_irq's are somewhat dynamically allocated and
the pointers are stored in a radix tree. While I convinced myself that
an inva
On 07/04/17 20:07, Stefano Stabellini wrote:
> On Fri, 7 Apr 2017, Andre Przywara wrote:
>> For LPIs the struct pending_irq's are somewhat dynamically allocated and
>> the pointers are stored in a radix tree. While I convinced myself that
>> an invalid LPI number can't make it into the core code, p
On Fri, 7 Apr 2017, Andre Przywara wrote:
> For LPIs the struct pending_irq's are somewhat dynamically allocated and
> the pointers are stored in a radix tree. While I convinced myself that
> an invalid LPI number can't make it into the core code, people might be
> concerned about NULL pointer dere
Hi Andre,
On 07/04/17 18:32, Andre Przywara wrote:
For LPIs the struct pending_irq's are somewhat dynamically allocated and
When I read "dynamically", I directly ask myself. What is protecting the
pending_irq structure to be freed whilst in-use in the vgic code?
In the current design, this
For LPIs the struct pending_irq's are somewhat dynamically allocated and
the pointers are stored in a radix tree. While I convinced myself that
an invalid LPI number can't make it into the core code, people might be
concerned about NULL pointer dereferences.
So add checks in some places just to be