Re: [Xen-devel] [PATCH v6 09/24] xsplice: Implement payload loading

2016-04-11 Thread Konrad Rzeszutek Wilk
On Mon, Apr 11, 2016 at 02:21:55PM -0400, Konrad Rzeszutek Wilk wrote: > On Mon, Apr 11, 2016 at 11:26:05AM -0600, Jan Beulich wrote: > > >>> On 11.04.16 at 19:08, wrote: > > > If the system admin continously tried to unload and load the patchset > > > then we certainly would spam. > > > > > > Bu

Re: [Xen-devel] [PATCH v6 09/24] xsplice: Implement payload loading

2016-04-11 Thread Konrad Rzeszutek Wilk
On Mon, Apr 11, 2016 at 11:26:05AM -0600, Jan Beulich wrote: > >>> On 11.04.16 at 19:08, wrote: > > If the system admin continously tried to unload and load the patchset > > then we certainly would spam. > > > > But the 'loading' is (or ought to) be a single event. The applying > > or reverting m

Re: [Xen-devel] [PATCH v6 09/24] xsplice: Implement payload loading

2016-04-11 Thread Jan Beulich
>>> On 11.04.16 at 19:08, wrote: > If the system admin continously tried to unload and load the patchset > then we certainly would spam. > > But the 'loading' is (or ought to) be a single event. The applying > or reverting may be done more often. > > As such I would say that the operations that

Re: [Xen-devel] [PATCH v6 09/24] xsplice: Implement payload loading

2016-04-11 Thread Konrad Rzeszutek Wilk
On Mon, Apr 11, 2016 at 10:55:38AM -0600, Jan Beulich wrote: > >>> On 11.04.16 at 18:34, wrote: > > On Mon, Apr 11, 2016 at 12:03:49PM -0400, Konrad Rzeszutek Wilk wrote: > >> On Mon, Apr 11, 2016 at 09:53:06AM -0600, Jan Beulich wrote: > >> > >>> On 09.04.16 at 02:37, wrote: > >> > > On Fri, Apr

Re: [Xen-devel] [PATCH v6 09/24] xsplice: Implement payload loading

2016-04-11 Thread Jan Beulich
>>> On 11.04.16 at 18:34, wrote: > On Mon, Apr 11, 2016 at 12:03:49PM -0400, Konrad Rzeszutek Wilk wrote: >> On Mon, Apr 11, 2016 at 09:53:06AM -0600, Jan Beulich wrote: >> > >>> On 09.04.16 at 02:37, wrote: >> > > On Fri, Apr 08, 2016 at 04:50:10PM -0600, Jan Beulich wrote: >> > >> >>> On 09.04.

Re: [Xen-devel] [PATCH v6 09/24] xsplice: Implement payload loading

2016-04-11 Thread Konrad Rzeszutek Wilk
On Mon, Apr 11, 2016 at 12:03:49PM -0400, Konrad Rzeszutek Wilk wrote: > On Mon, Apr 11, 2016 at 09:53:06AM -0600, Jan Beulich wrote: > > >>> On 09.04.16 at 02:37, wrote: > > > On Fri, Apr 08, 2016 at 04:50:10PM -0600, Jan Beulich wrote: > > >> >>> On 09.04.16 at 00:45, wrote: > > >> > On Fri, Ap

Re: [Xen-devel] [PATCH v6 09/24] xsplice: Implement payload loading

2016-04-11 Thread Konrad Rzeszutek Wilk
On Mon, Apr 11, 2016 at 09:53:06AM -0600, Jan Beulich wrote: > >>> On 09.04.16 at 02:37, wrote: > > On Fri, Apr 08, 2016 at 04:50:10PM -0600, Jan Beulich wrote: > >> >>> On 09.04.16 at 00:45, wrote: > >> > On Fri, Apr 08, 2016 at 03:18:09PM -0600, Jan Beulich wrote: > >> >> >>> On 08.04.16 at 23:

Re: [Xen-devel] [PATCH v6 09/24] xsplice: Implement payload loading

2016-04-11 Thread Jan Beulich
>>> On 09.04.16 at 02:37, wrote: > On Fri, Apr 08, 2016 at 04:50:10PM -0600, Jan Beulich wrote: >> >>> On 09.04.16 at 00:45, wrote: >> > On Fri, Apr 08, 2016 at 03:18:09PM -0600, Jan Beulich wrote: >> >> >>> On 08.04.16 at 23:10, wrote: >> >> >> > +int arch_xsplice_perform_rela(struct xsplice_el

Re: [Xen-devel] [PATCH v6 09/24] xsplice: Implement payload loading

2016-04-09 Thread Konrad Rzeszutek Wilk
On Fri, Apr 08, 2016 at 08:37:45PM -0400, Konrad Rzeszutek Wilk wrote: > On Fri, Apr 08, 2016 at 04:50:10PM -0600, Jan Beulich wrote: > > >>> On 09.04.16 at 00:45, wrote: > > > On Fri, Apr 08, 2016 at 03:18:09PM -0600, Jan Beulich wrote: > > >> >>> On 08.04.16 at 23:10, wrote: > > >> >> > +int ar

Re: [Xen-devel] [PATCH v6 09/24] xsplice: Implement payload loading

2016-04-08 Thread Konrad Rzeszutek Wilk
On Fri, Apr 08, 2016 at 04:50:10PM -0600, Jan Beulich wrote: > >>> On 09.04.16 at 00:45, wrote: > > On Fri, Apr 08, 2016 at 03:18:09PM -0600, Jan Beulich wrote: > >> >>> On 08.04.16 at 23:10, wrote: > >> >> > +int arch_xsplice_perform_rela(struct xsplice_elf *elf, > >> >> > +

Re: [Xen-devel] [PATCH v6 09/24] xsplice: Implement payload loading

2016-04-08 Thread Jan Beulich
>>> On 09.04.16 at 00:45, wrote: > On Fri, Apr 08, 2016 at 03:18:09PM -0600, Jan Beulich wrote: >> >>> On 08.04.16 at 23:10, wrote: >> >> > +int arch_xsplice_perform_rela(struct xsplice_elf *elf, >> >> > + const struct xsplice_elf_sec *base, >> >> > +

Re: [Xen-devel] [PATCH v6 09/24] xsplice: Implement payload loading

2016-04-08 Thread Konrad Rzeszutek Wilk
On Fri, Apr 08, 2016 at 03:18:09PM -0600, Jan Beulich wrote: > >>> On 08.04.16 at 23:10, wrote: > >> > +int arch_xsplice_perform_rela(struct xsplice_elf *elf, > >> > + const struct xsplice_elf_sec *base, > >> > + const struct xsplice_elf_se

Re: [Xen-devel] [PATCH v6 09/24] xsplice: Implement payload loading

2016-04-08 Thread Jan Beulich
>>> On 08.04.16 at 23:10, wrote: >> > +int arch_xsplice_perform_rela(struct xsplice_elf *elf, >> > + const struct xsplice_elf_sec *base, >> > + const struct xsplice_elf_sec *rela) >> > +{ >> > +const Elf_RelA *r; >> > +unsigned int

Re: [Xen-devel] [PATCH v6 09/24] xsplice: Implement payload loading

2016-04-08 Thread Konrad Rzeszutek Wilk
> > +int arch_xsplice_perform_rela(struct xsplice_elf *elf, > > + const struct xsplice_elf_sec *base, > > + const struct xsplice_elf_sec *rela) > > +{ > > +const Elf_RelA *r; > > +unsigned int symndx, i; > > +uint64_t val; > > +

Re: [Xen-devel] [PATCH v6 09/24] xsplice: Implement payload loading

2016-04-08 Thread Julien Grall
Hi Konrad, On 07/04/16 04:49, Konrad Rzeszutek Wilk wrote: From: Ross Lagerwall Add support for loading xsplice payloads. This is somewhat similar to the Linux kernel module loader, implementing the following steps: - Verify the elf file. - Parse the elf file. - Allocate a region of memory map

Re: [Xen-devel] [PATCH v6 09/24] xsplice: Implement payload loading

2016-04-08 Thread Andrew Cooper
On 07/04/16 04:49, Konrad Rzeszutek Wilk wrote: > diff --git a/xen/arch/x86/xsplice.c b/xen/arch/x86/xsplice.c > new file mode 100644 > index 000..cadf1f1 > --- /dev/null > +++ b/xen/arch/x86/xsplice.c > @@ -0,0 +1,199 @@ > +/* > + * Copyright (C) 2016 Citrix Systems R&D Ltd. > + */ > + > +#inc

[Xen-devel] [PATCH v6 09/24] xsplice: Implement payload loading

2016-04-06 Thread Konrad Rzeszutek Wilk
From: Ross Lagerwall Add support for loading xsplice payloads. This is somewhat similar to the Linux kernel module loader, implementing the following steps: - Verify the elf file. - Parse the elf file. - Allocate a region of memory mapped within a free area of [xen_virt_end, XEN_VIRT_END]. - Co