Re: [Xen-devel] [PATCH v6 04/15] x86: add multiboot2 protocol support

2016-09-21 Thread Jan Beulich
>>> On 21.09.16 at 10:56, wrote: > On Mon, Sep 19, 2016 at 05:42:36AM -0600, Jan Beulich wrote: >> >>> On 12.09.16 at 22:18, wrote: > > [...] > >> > +case MULTIBOOT2_TAG_TYPE_MODULE: >> > +if ( mod_idx >= mbi_out->mods_count ) >> > +break; >> > + >> > +

Re: [Xen-devel] [PATCH v6 04/15] x86: add multiboot2 protocol support

2016-09-21 Thread Daniel Kiper
On Mon, Sep 19, 2016 at 05:42:36AM -0600, Jan Beulich wrote: > >>> On 12.09.16 at 22:18, wrote: [...] > > +case MULTIBOOT2_TAG_TYPE_MODULE: > > +if ( mod_idx >= mbi_out->mods_count ) > > +break; > > + > > +mbi_out_mods[mod_idx].mod_start = get_mb2_

Re: [Xen-devel] [PATCH v6 04/15] x86: add multiboot2 protocol support

2016-09-19 Thread Jan Beulich
>>> On 12.09.16 at 22:18, wrote: > @@ -65,13 +82,11 @@ static u32 copy_string(u32 src) > return copy_mem(src, p - src + 1); > } > > -multiboot_info_t __stdcall *reloc(u32 mbi_in, u32 trampoline) > +static multiboot_info_t *mbi_mbi(u32 mbi_in) This is rather unhelpful a name - how about mb

[Xen-devel] [PATCH v6 04/15] x86: add multiboot2 protocol support

2016-09-12 Thread Daniel Kiper
Add multiboot2 protocol support. Alter min memory limit handling as we now may not find it from either multiboot (v1) or multiboot2. This way we are laying the foundation for EFI + GRUB2 + Xen development. Signed-off-by: Daniel Kiper --- v6 - suggestions/fixes: - properly index multiboot2_tag