Re: [Xen-devel] [PATCH v6] libxl: provide libxl_bitmap_{or,and}

2015-04-15 Thread Linda
On 4/15/2015 10:43 AM, Wei Liu wrote: On Wed, Apr 15, 2015 at 10:38:19AM -0600, Linda wrote: BTW who changes the configure file to test for the HAVE_ macros? The user (application) of libxl should test that. We don't need to worry about the test. Thanks. Linda Wei. _

Re: [Xen-devel] [PATCH v6] libxl: provide libxl_bitmap_{or,and}

2015-04-15 Thread Ian Campbell
On Wed, 2015-04-15 at 10:38 -0600, Linda wrote: Please stop top posting. > BTW who changes the configure file to test for the HAVE_ macros? Nobody, this is purely for the benefit of external callers of the library. No code in xen.git should ever check this #define (with a few exceptions which d

Re: [Xen-devel] [PATCH v6] libxl: provide libxl_bitmap_{or,and}

2015-04-15 Thread Wei Liu
On Wed, Apr 15, 2015 at 10:38:19AM -0600, Linda wrote: > BTW who changes the configure file to test for the HAVE_ macros? > The user (application) of libxl should test that. We don't need to worry about the test. Wei. ___ Xen-devel mailing list Xen-de

Re: [Xen-devel] [PATCH v6] libxl: provide libxl_bitmap_{or,and}

2015-04-15 Thread Linda
BTW who changes the configure file to test for the HAVE_ macros? Thanks. Linda On 4/15/2015 7:41 AM, Wei Liu wrote: On Wed, Apr 15, 2015 at 02:29:10PM +0100, Ian Campbell wrote: On Wed, 2015-04-15 at 14:15 +0100, Wei Liu wrote: On Wed, Apr 15, 2015 at 01:45:14PM +0100, Ian Campbell wrote: O

Re: [Xen-devel] [PATCH v6] libxl: provide libxl_bitmap_{or,and}

2015-04-15 Thread Linda
On 4/15/2015 9:54 AM, Ian Campbell wrote: On Wed, 2015-04-15 at 16:50 +0100, Wei Liu wrote: On Wed, Apr 15, 2015 at 09:13:51AM -0600, Linda wrote: When adding the HAVE macro, is there a protocol on where in libxl.h, this one should be placed? They appear to be fairly spread out through the f

Re: [Xen-devel] [PATCH v6] libxl: provide libxl_bitmap_{or,and}

2015-04-15 Thread Ian Campbell
On Wed, 2015-04-15 at 16:50 +0100, Wei Liu wrote: > On Wed, Apr 15, 2015 at 09:13:51AM -0600, Linda wrote: > > When adding the HAVE macro, is there a protocol on where in libxl.h, this > > one should be placed? They appear to be fairly spread out through the file. > > > > You can place it near t

Re: [Xen-devel] [PATCH v6] libxl: provide libxl_bitmap_{or,and}

2015-04-15 Thread Wei Liu
On Wed, Apr 15, 2015 at 09:13:51AM -0600, Linda wrote: > When adding the HAVE macro, is there a protocol on where in libxl.h, this > one should be placed? They appear to be fairly spread out through the file. > You can place it near the top. Wei. ___

Re: [Xen-devel] [PATCH v6] libxl: provide libxl_bitmap_{or,and}

2015-04-15 Thread Linda
When adding the HAVE macro, is there a protocol on where in libxl.h, this one should be placed? They appear to be fairly spread out through the file. Thanks. Linda On 4/15/2015 7:41 AM, Wei Liu wrote: On Wed, Apr 15, 2015 at 02:29:10PM +0100, Ian Campbell wrote: On Wed, 2015-04-15 at 14:15

Re: [Xen-devel] [PATCH v6] libxl: provide libxl_bitmap_{or,and}

2015-04-15 Thread Linda Jacobson
Sent from my iPhone > On Apr 15, 2015, at 7:41 AM, Wei Liu wrote: > >> On Wed, Apr 15, 2015 at 02:29:10PM +0100, Ian Campbell wrote: >>> On Wed, 2015-04-15 at 14:15 +0100, Wei Liu wrote: On Wed, Apr 15, 2015 at 01:45:14PM +0100, Ian Campbell wrote: > On Wed, 2015-04-15 at 05:45 -0600,

Re: [Xen-devel] [PATCH v6] libxl: provide libxl_bitmap_{or,and}

2015-04-15 Thread Wei Liu
On Wed, Apr 15, 2015 at 02:29:10PM +0100, Ian Campbell wrote: > On Wed, 2015-04-15 at 14:15 +0100, Wei Liu wrote: > > On Wed, Apr 15, 2015 at 01:45:14PM +0100, Ian Campbell wrote: > > > On Wed, 2015-04-15 at 05:45 -0600, Linda Jacobson wrote: > > > > There are new functions to provide logical and a

Re: [Xen-devel] [PATCH v6] libxl: provide libxl_bitmap_{or,and}

2015-04-15 Thread Ian Campbell
On Wed, 2015-04-15 at 14:15 +0100, Wei Liu wrote: > On Wed, Apr 15, 2015 at 01:45:14PM +0100, Ian Campbell wrote: > > On Wed, 2015-04-15 at 05:45 -0600, Linda Jacobson wrote: > > > There are new functions to provide logical and and or of two bitmaps. > > > > Please could you add a sentence or two

Re: [Xen-devel] [PATCH v6] libxl: provide libxl_bitmap_{or,and}

2015-04-15 Thread Wei Liu
On Wed, Apr 15, 2015 at 01:45:14PM +0100, Ian Campbell wrote: > On Wed, 2015-04-15 at 05:45 -0600, Linda Jacobson wrote: > > There are new functions to provide logical and and or of two bitmaps. > > Please could you add a sentence or two on the intended use of these > functions, since there are no

Re: [Xen-devel] [PATCH v6] libxl: provide libxl_bitmap_{or,and}

2015-04-15 Thread Ian Campbell
On Wed, 2015-04-15 at 05:45 -0600, Linda Jacobson wrote: > There are new functions to provide logical and and or of two bitmaps. Please could you add a sentence or two on the intended use of these functions, since there are no callers being added here. In particular without that I can't tell if t

[Xen-devel] [PATCH v6] libxl: provide libxl_bitmap_{or,and}

2015-04-15 Thread Linda Jacobson
There are new functions to provide logical and and or of two bitmaps. Signed-off-by: Linda Jacobson --- v.1 The new functions were added. v.2 The comments and format were corrected. v.3 The bitmap functions were rewritten to manipulate bytes not bits. v.4 Several non-modified parameters, and lo