Re: [Xen-devel] [PATCH v5 5/9] monitor: ARM SMC events

2016-06-07 Thread Tamas K Lengyel
On Jun 7, 2016 04:30, "Stefano Stabellini" wrote: > > On Tue, 7 Jun 2016, Jan Beulich wrote: > > >>> On 06.06.16 at 18:38, wrote: > > > On 06/06/16 17:14, Tamas K Lengyel wrote: > > >> On Mon, Jun 6, 2016 at 9:56 AM, Tamas K Lengyel wrote: > > >>> On Mon, Jun 6, 2016 at 9:54 AM, Julien Grall wr

Re: [Xen-devel] [PATCH v5 5/9] monitor: ARM SMC events

2016-06-07 Thread Stefano Stabellini
On Tue, 7 Jun 2016, Jan Beulich wrote: > >>> On 06.06.16 at 18:38, wrote: > > On 06/06/16 17:14, Tamas K Lengyel wrote: > >> On Mon, Jun 6, 2016 at 9:56 AM, Tamas K Lengyel > >> wrote: > >>> On Mon, Jun 6, 2016 at 9:54 AM, Julien Grall wrote: > >> So either way, I don't see a technical reason w

Re: [Xen-devel] [PATCH v5 5/9] monitor: ARM SMC events

2016-06-07 Thread Jan Beulich
>>> On 06.06.16 at 18:38, wrote: > On 06/06/16 17:14, Tamas K Lengyel wrote: >> On Mon, Jun 6, 2016 at 9:56 AM, Tamas K Lengyel wrote: >>> On Mon, Jun 6, 2016 at 9:54 AM, Julien Grall wrote: >> So either way, I don't see a technical reason why Xen should silently >> swallow any SMC trap if the v

Re: [Xen-devel] [PATCH v5 5/9] monitor: ARM SMC events

2016-06-06 Thread Tamas K Lengyel
On Mon, Jun 6, 2016 at 10:38 AM, Julien Grall wrote: > Hi Tamas, > > On 06/06/16 17:14, Tamas K Lengyel wrote: >> >> On Mon, Jun 6, 2016 at 9:56 AM, Tamas K Lengyel >> wrote: >>> >>> On Mon, Jun 6, 2016 at 9:54 AM, Julien Grall >>> wrote: >> >> So either way, I don't see a technical reason why X

Re: [Xen-devel] [PATCH v5 5/9] monitor: ARM SMC events

2016-06-06 Thread Julien Grall
Hi Tamas, On 06/06/16 17:14, Tamas K Lengyel wrote: On Mon, Jun 6, 2016 at 9:56 AM, Tamas K Lengyel wrote: On Mon, Jun 6, 2016 at 9:54 AM, Julien Grall wrote: So either way, I don't see a technical reason why Xen should silently swallow any SMC trap if the vm_event user specifically asked th

Re: [Xen-devel] [PATCH v5 5/9] monitor: ARM SMC events

2016-06-06 Thread Tamas K Lengyel
On Mon, Jun 6, 2016 at 9:56 AM, Tamas K Lengyel wrote: > On Mon, Jun 6, 2016 at 9:54 AM, Julien Grall wrote: >> Hello Tamas, >> >> On 06/06/16 16:24, Tamas K Lengyel wrote: >>> >>> >>> On Jun 6, 2016 04:08, "Julien Grall" >> > wrote: >>> > >>> > Hello, >>> > >>> >

Re: [Xen-devel] [PATCH v5 5/9] monitor: ARM SMC events

2016-06-06 Thread Julien Grall
Hello Tamas, On 06/06/16 16:24, Tamas K Lengyel wrote: On Jun 6, 2016 04:08, "Julien Grall" mailto:julien.gr...@arm.com>> wrote: > > Hello, > > > On 04/06/2016 18:40, Tamas K Lengyel wrote: >> >> On Sat, Jun 4, 2016 at 3:03 AM, Edgar E. Iglesias >> mailto:edgar.igles...@gmail.com>> wrot

Re: [Xen-devel] [PATCH v5 5/9] monitor: ARM SMC events

2016-06-06 Thread Tamas K Lengyel
On Mon, Jun 6, 2016 at 9:54 AM, Julien Grall wrote: > Hello Tamas, > > On 06/06/16 16:24, Tamas K Lengyel wrote: >> >> >> On Jun 6, 2016 04:08, "Julien Grall" > > wrote: >> > >> > Hello, >> > >> > >> > On 04/06/2016 18:40, Tamas K Lengyel wrote: >> >> >> >> On S

Re: [Xen-devel] [PATCH v5 5/9] monitor: ARM SMC events

2016-06-06 Thread Tamas K Lengyel
On Jun 6, 2016 04:08, "Julien Grall" wrote: > > Hello, > > > On 04/06/2016 18:40, Tamas K Lengyel wrote: >> >> On Sat, Jun 4, 2016 at 3:03 AM, Edgar E. Iglesias >> wrote: >>> >>> Forwarding SMC events for SMC insns that didn't pass the condition tests >>> doesn't make any sense to me. It'll just

Re: [Xen-devel] [PATCH v5 5/9] monitor: ARM SMC events

2016-06-06 Thread Julien Grall
Hello, On 04/06/2016 18:40, Tamas K Lengyel wrote: On Sat, Jun 4, 2016 at 3:03 AM, Edgar E. Iglesias wrote: Forwarding SMC events for SMC insns that didn't pass the condition tests doesn't make any sense to me. It'll just make the receivers job harder. Why would a receiver want to do anything

Re: [Xen-devel] [PATCH v5 5/9] monitor: ARM SMC events

2016-06-04 Thread Tamas K Lengyel
On Sat, Jun 4, 2016 at 3:03 AM, Edgar E. Iglesias wrote: > On Fri, Jun 03, 2016 at 09:34:20AM -0600, Tamas K Lengyel wrote: >> On Fri, Jun 3, 2016 at 9:27 AM, Tamas K Lengyel wrote: >> >>> > Furthermore, I think the vm_event app should only received SMCs whose >> >>> condition has succeeded, bec

Re: [Xen-devel] [PATCH v5 5/9] monitor: ARM SMC events

2016-06-04 Thread Edgar E. Iglesias
On Fri, Jun 03, 2016 at 09:34:20AM -0600, Tamas K Lengyel wrote: > On Fri, Jun 3, 2016 at 9:27 AM, Tamas K Lengyel wrote: > >>> > Furthermore, I think the vm_event app should only received SMCs whose > >>> condition has succeeded, because they will be actual SMC. The others > >>> should just be i

Re: [Xen-devel] [PATCH v5 5/9] monitor: ARM SMC events

2016-06-03 Thread Tamas K Lengyel
On Fri, Jun 3, 2016 at 9:06 AM, Julien Grall wrote: > > > On 03/06/16 16:03, Tamas K Lengyel wrote: >> >> If transmitting the ISS to the user this way is not enough in your >> opinion I may just leave this item up for a future user to implement >> as my use-case doesn't need it. > > > It is up to

Re: [Xen-devel] [PATCH v5 5/9] monitor: ARM SMC events

2016-06-03 Thread Tamas K Lengyel
On Fri, Jun 3, 2016 at 9:27 AM, Tamas K Lengyel wrote: >>> > Furthermore, I think the vm_event app should only received SMCs whose >>> condition has succeeded, because they will be actual SMC. The others >>> should just be ignored. >>> > >>> > IHMO, the vm_event should only contain the immediat

Re: [Xen-devel] [PATCH v5 5/9] monitor: ARM SMC events

2016-06-03 Thread Tamas K Lengyel
>> > Furthermore, I think the vm_event app should only received SMCs whose >> condition has succeeded, because they will be actual SMC. The others >> should just be ignored. >> > >> > IHMO, the vm_event should only contain the immediate. The rest only >> matters for the hypervisor. >> >> Absolut

Re: [Xen-devel] [PATCH v5 5/9] monitor: ARM SMC events

2016-06-03 Thread Julien Grall
On 03/06/16 16:03, Tamas K Lengyel wrote: If transmitting the ISS to the user this way is not enough in your opinion I may just leave this item up for a future user to implement as my use-case doesn't need it. It is up to you. However, it will likely mean to bump the interface version of the

Re: [Xen-devel] [PATCH v5 5/9] monitor: ARM SMC events

2016-06-03 Thread Tamas K Lengyel
On Fri, Jun 3, 2016 at 8:43 AM, Julien Grall wrote: > Hello Tamas, > > On 03/06/16 14:40, Tamas K Lengyel wrote: >> >> >> On Jun 3, 2016 03:49, "Julien Grall" > > wrote: >> > >> > Hello Tamas, >> > >> > >> > On 02/06/16 23:52, Tamas K Lengyel wrote: >> >> >> >>

Re: [Xen-devel] [PATCH v5 5/9] monitor: ARM SMC events

2016-06-03 Thread Julien Grall
Hello Tamas, On 03/06/16 14:40, Tamas K Lengyel wrote: On Jun 3, 2016 03:49, "Julien Grall" mailto:julien.gr...@arm.com>> wrote: > > Hello Tamas, > > > On 02/06/16 23:52, Tamas K Lengyel wrote: >> >> diff --git a/xen/include/public/vm_event.h b/xen/include/public/vm_event.h >> index 927

Re: [Xen-devel] [PATCH v5 5/9] monitor: ARM SMC events

2016-06-03 Thread Tamas K Lengyel
On Jun 3, 2016 03:49, "Julien Grall" wrote: > > Hello Tamas, > > > On 02/06/16 23:52, Tamas K Lengyel wrote: >> >> diff --git a/xen/include/public/vm_event.h b/xen/include/public/vm_event.h >> index 9270d52..7976080 100644 >> --- a/xen/include/public/vm_event.h >> +++ b/xen/include/public/vm_event

Re: [Xen-devel] [PATCH v5 5/9] monitor: ARM SMC events

2016-06-03 Thread Julien Grall
Hello Tamas, On 02/06/16 23:52, Tamas K Lengyel wrote: diff --git a/xen/include/public/vm_event.h b/xen/include/public/vm_event.h index 9270d52..7976080 100644 --- a/xen/include/public/vm_event.h +++ b/xen/include/public/vm_event.h @@ -119,6 +119,8 @@ #define VM_EVENT_REASON_SINGLESTEP

[Xen-devel] [PATCH v5 5/9] monitor: ARM SMC events

2016-06-02 Thread Tamas K Lengyel
Add support for monitoring ARM SMC events. This patch only adds the required bits to enable/disable monitoring and forwarding the event through vm_event. Signed-off-by: Tamas K Lengyel Acked-by: Razvan Cojocaru --- Cc: Stefano Stabellini Cc: Julien Grall v5: Add struct vm_event_privcall to ho