On Fri, Feb 13, 2015 at 03:26:49PM +, Ian Jackson wrote:
> Wei Liu writes ("Re: [PATCH v5 19/24] libxl: define LIBXL_HAVE_VNUMA"):
> > There is no new API yet. Just new structure to specify vNUMA
> > configuration.
> >
> > How about this:
> >
> > /* LIBXL_HAVE_VNUMA
> > *
> > * If this is d
Wei Liu writes ("Re: [PATCH v5 19/24] libxl: define LIBXL_HAVE_VNUMA"):
> There is no new API yet. Just new structure to specify vNUMA
> configuration.
>
> How about this:
>
> /* LIBXL_HAVE_VNUMA
> *
> * If this is defined, libxl's IDL has libxl_vnode_info and there is a
> * array call vnuma_n
Ian Jackson writes ("Re: [PATCH v5 19/24] libxl: define LIBXL_HAVE_VNUMA"):
> Yes, something like that. It would be better if the precise wording
> were more similar to that for the other HAVE macros. How about:
>
>* If this is defined the type libxl_vnode_info exists, and a
>* field 'vn
On Fri, Feb 13, 2015 at 02:12:58PM +, Ian Jackson wrote:
> Wei Liu writes ("[PATCH v5 19/24] libxl: define LIBXL_HAVE_VNUMA"):
> > Signed-off-by: Wei Liu
> ...
> > +/* LIBXL_HAVE_VNUMA
> > + *
> > + * If it is defined, libxl supports vNUMA configuration
> > + */
>
> I think you should be more
Wei Liu writes ("[PATCH v5 19/24] libxl: define LIBXL_HAVE_VNUMA"):
> Signed-off-by: Wei Liu
...
> +/* LIBXL_HAVE_VNUMA
> + *
> + * If it is defined, libxl supports vNUMA configuration
> + */
I think you should be more specific about which calls are covered.
Ian.
___
Signed-off-by: Wei Liu
Cc: Ian Campbell
Cc: Ian Jackson
---
tools/libxl/libxl.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/tools/libxl/libxl.h b/tools/libxl/libxl.h
index c219f59..f33178c 100644
--- a/tools/libxl/libxl.h
+++ b/tools/libxl/libxl.h
@@ -67,6 +67,12 @@
* the same $
