Re: [Xen-devel] [PATCH v5 09/28] xsplice: Add helper elf routines

2016-04-06 Thread Jan Beulich
>>> Konrad Rzeszutek Wilk 04/06/16 3:40 AM >>> >> > +struct xsplice_elf_sym { >> > +Elf_Sym *sym; >> >> const? > >.. this is much harder. I end up computing the values for >these symbols and have to write to this this structure a couple of times >(at worst). So I've intentionally added quest

Re: [Xen-devel] [PATCH v5 09/28] xsplice: Add helper elf routines

2016-04-05 Thread Konrad Rzeszutek Wilk
> > +static int elf_resolve_sections(struct xsplice_elf *elf, const void *data) > > +{ .. snip.. > > +/* N.B. We also will ingest SHN_UNDEF sections. */ > > Because of? The meaning of the fields in the 0-th section header is > different from that of ordinary ones. > > > +for ( i = 0; i <

Re: [Xen-devel] [PATCH v5 09/28] xsplice: Add helper elf routines

2016-03-31 Thread Jan Beulich
>>> On 24.03.16 at 21:00, wrote: > --- /dev/null > +++ b/xen/common/xsplice_elf.c > @@ -0,0 +1,294 @@ > +/* > + * Copyright (C) 2016 Citrix Systems R&D Ltd. > + */ > + > +#include > +#include > +#include > +#include > + > +struct xsplice_elf_sec *xsplice_elf_sec_by_name(const struct xsplice_el

[Xen-devel] [PATCH v5 09/28] xsplice: Add helper elf routines

2016-03-24 Thread Konrad Rzeszutek Wilk
From: Ross Lagerwall Add Elf routines and data structures in preparation for loading an xSplice payload. We make an assumption that the max number of sections an ELF payload can have is 64. We can in future make this be dependent on the names of the sections and verifying against a list, but for