Re: [Xen-devel] [PATCH v5 08/14] hvmloader: Locate the BIOS blob

2016-06-30 Thread Jan Beulich
>>> On 30.06.16 at 17:04, wrote: > On Mon, Jun 27, 2016 at 01:13:43AM -0600, Jan Beulich wrote: >> >>> On 24.06.16 at 19:02, wrote: >> > On Fri, Jun 24, 2016 at 01:33:45AM -0600, Jan Beulich wrote: >> >> >>> On 22.06.16 at 19:15, wrote: >> >> > +for ( i = 0; i < info->nr_modules; i++ ) >> >>

Re: [Xen-devel] [PATCH v5 08/14] hvmloader: Locate the BIOS blob

2016-06-30 Thread Anthony PERARD
On Mon, Jun 27, 2016 at 01:13:43AM -0600, Jan Beulich wrote: > >>> On 24.06.16 at 19:02, wrote: > > On Fri, Jun 24, 2016 at 01:33:45AM -0600, Jan Beulich wrote: > >> >>> On 22.06.16 at 19:15, wrote: > >> > --- a/tools/firmware/hvmloader/hvmloader.c > >> > +++ b/tools/firmware/hvmloader/hvmloader.

Re: [Xen-devel] [PATCH v5 08/14] hvmloader: Locate the BIOS blob

2016-06-27 Thread Jan Beulich
>>> On 24.06.16 at 19:02, wrote: > On Fri, Jun 24, 2016 at 01:33:45AM -0600, Jan Beulich wrote: >> >>> On 22.06.16 at 19:15, wrote: >> > --- a/tools/firmware/hvmloader/hvmloader.c >> > +++ b/tools/firmware/hvmloader/hvmloader.c >> > @@ -253,10 +253,51 @@ static void acpi_enable_sci(void) >> >

Re: [Xen-devel] [PATCH v5 08/14] hvmloader: Locate the BIOS blob

2016-06-24 Thread Anthony PERARD
On Fri, Jun 24, 2016 at 01:33:45AM -0600, Jan Beulich wrote: > >>> On 22.06.16 at 19:15, wrote: > > --- a/tools/firmware/hvmloader/hvmloader.c > > +++ b/tools/firmware/hvmloader/hvmloader.c > > @@ -253,10 +253,51 @@ static void acpi_enable_sci(void) > > BUG_ON(!(pm1a_cnt_val & ACPI_PM1C_SCI_E

Re: [Xen-devel] [PATCH v5 08/14] hvmloader: Locate the BIOS blob

2016-06-24 Thread Jan Beulich
>>> On 22.06.16 at 19:15, wrote: > --- a/tools/firmware/hvmloader/hvmloader.c > +++ b/tools/firmware/hvmloader/hvmloader.c > @@ -253,10 +253,51 @@ static void acpi_enable_sci(void) > BUG_ON(!(pm1a_cnt_val & ACPI_PM1C_SCI_EN)); > } > > +const struct hvm_modlist_entry *get_module_entry( > +

[Xen-devel] [PATCH v5 08/14] hvmloader: Locate the BIOS blob

2016-06-22 Thread Anthony PERARD
The BIOS blob can be found an entry called "firmware" of the modlist of the hvm_start_info struct. The found BIOS blob is not loaded by this patch, but only passed as argument to bios_load() function. Signed-off-by: Anthony PERARD --- Changes in V5: - don't BUG() on module's paddr having value