Re: [Xen-devel] [PATCH v5 08/13] x86/traps: factor out pv_trap_init

2017-06-28 Thread Andrew Cooper
On 27/06/17 19:19, Jan Beulich wrote: Andrew Cooper 06/27/17 8:06 PM >>> >> On 26/06/17 17:28, Wei Liu wrote: >>> --- a/xen/arch/x86/traps.c >>> +++ b/xen/arch/x86/traps.c >>> @@ -1934,21 +1934,29 @@ void __init init_idt_traps(void) >>> this_cpu(compat_gdt_table) = boot_cpu_compat_gdt_ta

Re: [Xen-devel] [PATCH v5 08/13] x86/traps: factor out pv_trap_init

2017-06-28 Thread Wei Liu
On Wed, Jun 28, 2017 at 11:06:58AM +0100, Wei Liu wrote: > On Tue, Jun 27, 2017 at 12:26:52PM -0600, Jan Beulich wrote: > > >>> Wei Liu 06/26/17 6:29 PM >>> > > >--- a/xen/arch/x86/traps.c > > >+++ b/xen/arch/x86/traps.c > > >@@ -1934,21 +1934,29 @@ void __init init_idt_traps(void) > > >this_

Re: [Xen-devel] [PATCH v5 08/13] x86/traps: factor out pv_trap_init

2017-06-28 Thread Wei Liu
On Tue, Jun 27, 2017 at 12:26:52PM -0600, Jan Beulich wrote: > >>> Wei Liu 06/26/17 6:29 PM >>> > >--- a/xen/arch/x86/traps.c > >+++ b/xen/arch/x86/traps.c > >@@ -1934,21 +1934,29 @@ void __init init_idt_traps(void) > >this_cpu(compat_gdt_table) = boot_cpu_compat_gdt_table; > >} > > > >+voi

Re: [Xen-devel] [PATCH v5 08/13] x86/traps: factor out pv_trap_init

2017-06-27 Thread Jan Beulich
>>> Wei Liu 06/26/17 6:29 PM >>> >--- a/xen/arch/x86/traps.c >+++ b/xen/arch/x86/traps.c >@@ -1934,21 +1934,29 @@ void __init init_idt_traps(void) >this_cpu(compat_gdt_table) = boot_cpu_compat_gdt_table; >} > >+void __init pv_trap_init(void) >+{ >+/* The 32-on-64 hypercall vector is onl

Re: [Xen-devel] [PATCH v5 08/13] x86/traps: factor out pv_trap_init

2017-06-27 Thread Jan Beulich
>>> Andrew Cooper 06/27/17 8:06 PM >>> >On 26/06/17 17:28, Wei Liu wrote: >> --- a/xen/arch/x86/traps.c >> +++ b/xen/arch/x86/traps.c >> @@ -1934,21 +1934,29 @@ void __init init_idt_traps(void) >> this_cpu(compat_gdt_table) = boot_cpu_compat_gdt_table; >> } >> >> +void __init pv_trap_init(

Re: [Xen-devel] [PATCH v5 08/13] x86/traps: factor out pv_trap_init

2017-06-27 Thread Andrew Cooper
On 26/06/17 17:28, Wei Liu wrote: > Factor out pv_trap_init and call it at the beginning of trap_init. We > then need to tune the code to generate stub handlers in entry.S. Take > the chance to tune init_irq_data so that 0x80 and 0x82 can be used in > !CONFIG_PV case. "used for regular interrupts

[Xen-devel] [PATCH v5 08/13] x86/traps: factor out pv_trap_init

2017-06-26 Thread Wei Liu
Factor out pv_trap_init and call it at the beginning of trap_init. We then need to tune the code to generate stub handlers in entry.S. Take the chance to tune init_irq_data so that 0x80 and 0x82 can be used in !CONFIG_PV case. While at it, fix some coding style issues in init_irq_data and replace