Re: [Xen-devel] [PATCH v5 06/13] x86: simplify guest_has_trap_callback

2017-06-27 Thread Wei Liu
On Tue, Jun 27, 2017 at 12:09:14AM -0600, Jan Beulich wrote: > >>> Andrew Cooper 06/26/17 6:58 PM >>> > >On 26/06/17 17:28, Wei Liu wrote: > >> --- a/xen/arch/x86/cpu/mcheck/vmce.c > >> +++ b/xen/arch/x86/cpu/mcheck/vmce.c > >> @@ -359,6 +359,15 @@ static int vmce_load_vcpu_ctxt(struct domain *d,

Re: [Xen-devel] [PATCH v5 06/13] x86: simplify guest_has_trap_callback

2017-06-26 Thread Jan Beulich
>>> Andrew Cooper 06/26/17 6:58 PM >>> >On 26/06/17 17:28, Wei Liu wrote: >> --- a/xen/arch/x86/cpu/mcheck/vmce.c >> +++ b/xen/arch/x86/cpu/mcheck/vmce.c >> @@ -359,6 +359,15 @@ static int vmce_load_vcpu_ctxt(struct domain *d, >> hvm_domain_context_t *h) >> HVM_REGISTER_SAVE_RESTORE(VMCE_VCPU, v

Re: [Xen-devel] [PATCH v5 06/13] x86: simplify guest_has_trap_callback

2017-06-26 Thread Andrew Cooper
On 26/06/17 17:28, Wei Liu wrote: > There is only one caller for that function. Simplify the function, > move it close to the caller and rename it. > > Signed-off-by: Wei Liu Good improvement. In principle, Reviewed-by: Andrew Cooper , although... > --- > xen/arch/x86/cpu/mcheck/vmce.c | 11 ++

[Xen-devel] [PATCH v5 06/13] x86: simplify guest_has_trap_callback

2017-06-26 Thread Wei Liu
There is only one caller for that function. Simplify the function, move it close to the caller and rename it. Signed-off-by: Wei Liu --- xen/arch/x86/cpu/mcheck/vmce.c | 11 ++- xen/arch/x86/traps.c | 18 -- xen/include/asm-x86/traps.h| 8 3 files