Re: [Xen-devel] [PATCH v5 05/22] xen/arm: ITS: Port ITS driver to Xen

2015-07-31 Thread Julien Grall
On 31/07/15 11:28, Vijay Kilari wrote: > On Tue, Jul 28, 2015 at 10:16 PM, Julien Grall > wrote: >> Hi Vijay, >> >> On 27/07/15 12:11, vijay.kil...@gmail.com wrote: >>> From: Vijaya Kumar K >>> >>> The linux driver is based on 4.1 with below commit id >>> >>> 3ad2a5f57656a14d964b673a5a0e4ab0e583

Re: [Xen-devel] [PATCH v5 05/22] xen/arm: ITS: Port ITS driver to Xen

2015-07-31 Thread Vijay Kilari
On Tue, Jul 28, 2015 at 10:16 PM, Julien Grall wrote: > Hi Vijay, > > On 27/07/15 12:11, vijay.kil...@gmail.com wrote: >> From: Vijaya Kumar K >> >> The linux driver is based on 4.1 with below commit id >> >> 3ad2a5f57656a14d964b673a5a0e4ab0e583c870 > > This doesn't include commit 591e5bec13f15fe

Re: [Xen-devel] [PATCH v5 05/22] xen/arm: ITS: Port ITS driver to Xen

2015-07-29 Thread Vijay Kilari
On Wed, Jul 29, 2015 at 9:36 PM, Ian Campbell wrote: > On Wed, 2015-07-29 at 20:52 +0530, Vijay Kilari wrote: >> Hi Julien, >> >> Can you please explain what is the problem with making a function >> non-static for compilation purpose and later make it static when used? > > It's noise in the seri

Re: [Xen-devel] [PATCH v5 05/22] xen/arm: ITS: Port ITS driver to Xen

2015-07-29 Thread Ian Campbell
On Wed, 2015-07-29 at 20:52 +0530, Vijay Kilari wrote: > Hi Julien, > > Can you please explain what is the problem with making a function > non-static for compilation purpose and later make it static when used? It's noise in the series, which makes it harder to review and it is noise in the his

Re: [Xen-devel] [PATCH v5 05/22] xen/arm: ITS: Port ITS driver to Xen

2015-07-29 Thread Vijay Kilari
Hi Julien, Can you please explain what is the problem with making a function non-static for compilation purpose and later make it static when used? In anycase we are going to merge all the patches at once. Regards Vijay On Tue, Jul 28, 2015 at 10:16 PM, Julien Grall wrote: > Hi Vijay, > > On

Re: [Xen-devel] [PATCH v5 05/22] xen/arm: ITS: Port ITS driver to Xen

2015-07-28 Thread Julien Grall
Hi Vijay, On 27/07/15 12:11, vijay.kil...@gmail.com wrote: > From: Vijaya Kumar K > > The linux driver is based on 4.1 with below commit id > > 3ad2a5f57656a14d964b673a5a0e4ab0e583c870 This doesn't include commit 591e5bec13f15feb13fc445b6c9c59954711c4ac "irqchip/gicv3-its: Fix mapping of LPIs

[Xen-devel] [PATCH v5 05/22] xen/arm: ITS: Port ITS driver to Xen

2015-07-27 Thread vijay . kilari
From: Vijaya Kumar K The linux driver is based on 4.1 with below commit id 3ad2a5f57656a14d964b673a5a0e4ab0e583c870 Only following code from Linux ITS driver is ported and compiled - LPI initialization - ITS configuration code - Physical command queue management - ITS command building Also