On 30/06/15 14:05, Paul Durrant wrote:
> -bool_t hvm_mmio_internal(paddr_t gpa)
> +static int hvm_portio_read(const struct hvm_io_handler *handler,
> + uint64_t addr,
> + uint32_t size,
> + uint64_t *data)
> {
> -str
gt; >> Cc: Andrew Cooper; Keir (Xen.org); Jan Beulich
> >> Subject: Re: [Xen-devel] [PATCH v5 05/16] x86/hvm: unify internal portio
> and
> >> mmio intercepts
> >>
> >> El 30/06/15 a les 15.05, Paul Durrant ha escrit:
> >> [...]
> >> +vo
> Subject: Re: [Xen-devel] [PATCH v5 05/16] x86/hvm: unify internal portio and
>> mmio intercepts
>>
>> El 30/06/15 a les 15.05, Paul Durrant ha escrit:
>> [...]
>> +void msixtbl_init(struct domain *d)
>>> +{
>>> +register_mmio_handler(d, &
> -Original Message-
> From: Roger Pau Monné [mailto:roger@citrix.com]
> Sent: 02 July 2015 15:52
> To: Paul Durrant; xen-de...@lists.xenproject.org
> Cc: Andrew Cooper; Keir (Xen.org); Jan Beulich
> Subject: Re: [Xen-devel] [PATCH v5 05/16] x86/hvm: unify internal
El 30/06/15 a les 15.05, Paul Durrant ha escrit:
[...]
+void msixtbl_init(struct domain *d)
> +{
> +register_mmio_handler(d, &msixtbl_mmio_ops);
Since you are adding an initialization function to vmsi I think
msixtbl_list and msixtbl_list_lock should also be initialized here
instead of hvm_dom
The implementation of mmio and portio intercepts is unnecessarily different.
This leads to much code duplication. This patch unifies much of the
intercept handling, leaving only distinct handlers for stdvga mmio and dpci
portio. Subsequent patches will unify those handlers.
Signed-off-by: Paul Dur
