Re: [Xen-devel] [PATCH v4.2] libxc: Defer initialization of start_page for HVM guests

2016-01-19 Thread Ian Campbell
On Tue, 2016-01-19 at 15:13 +, Ian Campbell wrote: > On Tue, 2016-01-19 at 10:02 -0500, Boris Ostrovsky wrote: > > On 01/08/2016 10:11 AM, Ian Campbell wrote: > > > > > > BTW, it might be possible to use xc_dom_seg_to_ptr instead of an open > > > coded > > > xc_map_foreign? Although it wasn't

Re: [Xen-devel] [PATCH v4.2] libxc: Defer initialization of start_page for HVM guests

2016-01-19 Thread Ian Campbell
On Tue, 2016-01-19 at 10:02 -0500, Boris Ostrovsky wrote: > On 01/08/2016 10:11 AM, Ian Campbell wrote: > > > > BTW, it might be possible to use xc_dom_seg_to_ptr instead of an open > > coded > > xc_map_foreign? Although it wasn't used before and maybe there is a > > reason > > for that which stil

Re: [Xen-devel] [PATCH v4.2] libxc: Defer initialization of start_page for HVM guests

2016-01-19 Thread Boris Ostrovsky
On 01/08/2016 10:11 AM, Ian Campbell wrote: BTW, it might be possible to use xc_dom_seg_to_ptr instead of an open coded xc_map_foreign? Although it wasn't used before and maybe there is a reason for that which still applies. Is this waiting for me to replace xc_map_foreign() with xc_dom_seg_

Re: [Xen-devel] [PATCH v4.2] libxc: Defer initialization of start_page for HVM guests

2016-01-08 Thread Roger Pau Monné
El 08/01/16 a les 16.11, Ian Campbell ha escrit: > On Fri, 2016-01-08 at 09:53 -0500, Boris Ostrovsky wrote: >> On 01/08/2016 09:30 AM, Juergen Gross wrote: >>> On 08/01/16 15:19, Boris Ostrovsky wrote: On 01/07/2016 11:57 PM, Juergen Gross wrote: > On 07/01/16 23:19, Boris Ostrovsky wrote

Re: [Xen-devel] [PATCH v4.2] libxc: Defer initialization of start_page for HVM guests

2016-01-08 Thread Boris Ostrovsky
On 01/08/2016 10:11 AM, Ian Campbell wrote: On Fri, 2016-01-08 at 09:53 -0500, Boris Ostrovsky wrote: On 01/08/2016 09:30 AM, Juergen Gross wrote: On 08/01/16 15:19, Boris Ostrovsky wrote: On 01/07/2016 11:57 PM, Juergen Gross wrote: On 07/01/16 23:19, Boris Ostrovsky wrote: With commit 8c45

Re: [Xen-devel] [PATCH v4.2] libxc: Defer initialization of start_page for HVM guests

2016-01-08 Thread Ian Campbell
On Fri, 2016-01-08 at 09:53 -0500, Boris Ostrovsky wrote: > On 01/08/2016 09:30 AM, Juergen Gross wrote: > > On 08/01/16 15:19, Boris Ostrovsky wrote: > > > On 01/07/2016 11:57 PM, Juergen Gross wrote: > > > > On 07/01/16 23:19, Boris Ostrovsky wrote: > > > > > With commit 8c45adec18e0 ("libxc: cre

Re: [Xen-devel] [PATCH v4.2] libxc: Defer initialization of start_page for HVM guests

2016-01-08 Thread Boris Ostrovsky
On 01/08/2016 09:30 AM, Juergen Gross wrote: On 08/01/16 15:19, Boris Ostrovsky wrote: On 01/07/2016 11:57 PM, Juergen Gross wrote: On 07/01/16 23:19, Boris Ostrovsky wrote: With commit 8c45adec18e0 ("libxc: create unmapped initrd in domain builder if supported") location of ramdisk may not be

Re: [Xen-devel] [PATCH v4.2] libxc: Defer initialization of start_page for HVM guests

2016-01-08 Thread Ian Campbell
On Fri, 2016-01-08 at 09:19 -0500, Boris Ostrovsky wrote: > index 2460818..cac4698 100644 > > > --- a/tools/libxc/include/xc_dom.h > > > +++ b/tools/libxc/include/xc_dom.h > > > @@ -71,6 +71,7 @@ struct xc_dom_image { > > >   > > >   /* arguments and parameters */ > > >   char *cmdline; >

Re: [Xen-devel] [PATCH v4.2] libxc: Defer initialization of start_page for HVM guests

2016-01-08 Thread Juergen Gross
On 08/01/16 15:19, Boris Ostrovsky wrote: > On 01/07/2016 11:57 PM, Juergen Gross wrote: >> On 07/01/16 23:19, Boris Ostrovsky wrote: >>> With commit 8c45adec18e0 ("libxc: create unmapped initrd in domain >>> builder if supported") location of ramdisk may not be available to >>> HVMlite guests by t

Re: [Xen-devel] [PATCH v4.2] libxc: Defer initialization of start_page for HVM guests

2016-01-08 Thread Boris Ostrovsky
On 01/07/2016 11:57 PM, Juergen Gross wrote: On 07/01/16 23:19, Boris Ostrovsky wrote: With commit 8c45adec18e0 ("libxc: create unmapped initrd in domain builder if supported") location of ramdisk may not be available to HVMlite guests by the time alloc_magic_pages_hvm() is invoked if the guest

Re: [Xen-devel] [PATCH v4.2] libxc: Defer initialization of start_page for HVM guests

2016-01-08 Thread Ian Campbell
On Thu, 2016-01-07 at 17:19 -0500, Boris Ostrovsky wrote: > v4: >  * See the last two paragraphs from commit message above > > v4.1: >  * Inverted testing of start_info_size in bootlate_hvm(). > > v4.2 >  * Actually do what I said I'd do in 4.1 I was so proud of myself for spotting 4.1 just bef

Re: [Xen-devel] [PATCH v4.2] libxc: Defer initialization of start_page for HVM guests

2016-01-07 Thread Juergen Gross
On 07/01/16 23:19, Boris Ostrovsky wrote: > With commit 8c45adec18e0 ("libxc: create unmapped initrd in domain > builder if supported") location of ramdisk may not be available to > HVMlite guests by the time alloc_magic_pages_hvm() is invoked if the > guest supports unmapped initrd. > > So let's

[Xen-devel] [PATCH v4.2] libxc: Defer initialization of start_page for HVM guests

2016-01-07 Thread Boris Ostrovsky
With commit 8c45adec18e0 ("libxc: create unmapped initrd in domain builder if supported") location of ramdisk may not be available to HVMlite guests by the time alloc_magic_pages_hvm() is invoked if the guest supports unmapped initrd. So let's move ramdisk info initialization (along with a few oth