Re: [Xen-devel] [PATCH v4 6/6] x86emul: improve CR/DR access handling

2017-01-11 Thread Andrew Cooper
On 10/01/17 13:01, Jan Beulich wrote: On 10.01.17 at 12:59, wrote: >> On 10/01/17 09:06, Jan Beulich wrote: >>> - don't accept LOCK for DR accesses (it's undefined in the manuals) >>> - only accept LOCK for CR accesses when the respective feature flag is >>> set (which would not normally be

Re: [Xen-devel] [PATCH v4 6/6] x86emul: improve CR/DR access handling

2017-01-10 Thread Jan Beulich
>>> On 10.01.17 at 12:59, wrote: > On 10/01/17 09:06, Jan Beulich wrote: >> - don't accept LOCK for DR accesses (it's undefined in the manuals) >> - only accept LOCK for CR accesses when the respective feature flag is >> set (which would not normally be the case for Intel) >> - add (rather than

Re: [Xen-devel] [PATCH v4 6/6] x86emul: improve CR/DR access handling

2017-01-10 Thread Andrew Cooper
On 10/01/17 09:06, Jan Beulich wrote: > - don't accept LOCK for DR accesses (it's undefined in the manuals) > - only accept LOCK for CR accesses when the respective feature flag is > set (which would not normally be the case for Intel) > - add (rather than or) 8 when LOCK is present; real hardwar

[Xen-devel] [PATCH v4 6/6] x86emul: improve CR/DR access handling

2017-01-10 Thread Jan Beulich
- don't accept LOCK for DR accesses (it's undefined in the manuals) - only accept LOCK for CR accesses when the respective feature flag is set (which would not normally be the case for Intel) - add (rather than or) 8 when LOCK is present; real hardware #UDs when both REX.W and LOCK are present,