Re: [Xen-devel] [PATCH v4 5/9] sysctl: Add sysctl interface for querying PCI topology

2015-03-13 Thread Boris Ostrovsky
On 03/13/2015 12:03 PM, Jan Beulich wrote: On 10.03.15 at 03:27, wrote: +case XEN_SYSCTL_pcitopoinfo: +{ +xen_sysctl_pcitopoinfo_t *ti = &op->u.pcitopoinfo; + +if ( guest_handle_is_null(ti->devs) || + guest_handle_is_null(ti->nodes) || + (ti->firs

Re: [Xen-devel] [PATCH v4 5/9] sysctl: Add sysctl interface for querying PCI topology

2015-03-13 Thread Jan Beulich
>>> On 10.03.15 at 03:27, wrote: > +case XEN_SYSCTL_pcitopoinfo: > +{ > +xen_sysctl_pcitopoinfo_t *ti = &op->u.pcitopoinfo; > + > +if ( guest_handle_is_null(ti->devs) || > + guest_handle_is_null(ti->nodes) || > + (ti->first_dev > ti->num_devs) ) > +

Re: [Xen-devel] [PATCH v4 5/9] sysctl: Add sysctl interface for querying PCI topology

2015-03-10 Thread Andrew Cooper
On 10/03/15 02:27, Boris Ostrovsky wrote: > Signed-off-by: Boris Ostrovsky > --- > > Changes in v4: > * No buffer allocation in sysctl, copy data device-by-device > * Replace INVALID_TOPOLOGY_ID with XEN_INVALID_NODE_ID > > xen/common/sysctl.c | 59 > +++

[Xen-devel] [PATCH v4 5/9] sysctl: Add sysctl interface for querying PCI topology

2015-03-09 Thread Boris Ostrovsky
Signed-off-by: Boris Ostrovsky --- Changes in v4: * No buffer allocation in sysctl, copy data device-by-device * Replace INVALID_TOPOLOGY_ID with XEN_INVALID_NODE_ID xen/common/sysctl.c | 59 +++ xen/include/public/sysctl.h | 29 ++