Re: [Xen-devel] [PATCH v4 5/8] dm_op: convert HVMOP_modified_memory

2017-01-20 Thread Andrew Cooper
On 17/01/17 17:29, Paul Durrant wrote: > diff --git a/xen/arch/x86/hvm/dm.c b/xen/arch/x86/hvm/dm.c > index 12a82e5..dd81116 100644 > --- a/xen/arch/x86/hvm/dm.c > +++ b/xen/arch/x86/hvm/dm.c > @@ -14,6 +14,7 @@ > * this program; If not, see . > */ > > +#include

Re: [Xen-devel] [PATCH v4 5/8] dm_op: convert HVMOP_modified_memory

2017-01-20 Thread Jan Beulich
>>> On 17.01.17 at 18:29, wrote: > v4: > - Continuation code in dm.c modified as knock-on from compat code. Not > adding Jan's R-b since patch has fundamentally changed. Same here - other than the same code being added to compat_dm_op(), I'm unable to spot any meaningful changes. Jan ___

Re: [Xen-devel] [PATCH v4 5/8] dm_op: convert HVMOP_modified_memory

2017-01-18 Thread Daniel De Graaf
On 01/17/2017 12:29 PM, Paul Durrant wrote: This patch introduces code to handle DMOP continuations. NOTE: This patch also modifies the type of the 'nr' argument of xc_hvm_modified_memory() from uint64_t to uint32_t. In practice the value passed was always truncated to 32 bits. Sugg

[Xen-devel] [PATCH v4 5/8] dm_op: convert HVMOP_modified_memory

2017-01-17 Thread Paul Durrant
This patch introduces code to handle DMOP continuations. NOTE: This patch also modifies the type of the 'nr' argument of xc_hvm_modified_memory() from uint64_t to uint32_t. In practice the value passed was always truncated to 32 bits. Suggested-by: Jan Beulich Signed-off-by: Paul Dur