Re: [Xen-devel] [PATCH v4 4/4] build: enable no-parentheses in clang

2017-02-14 Thread Jan Beulich
>>> On 14.02.17 at 15:13, wrote: > On 14/02/17 14:06, Roger Pau Monne wrote: >> On Tue, Feb 14, 2017 at 06:56:12AM -0700, Jan Beulich wrote: >> On 14.02.17 at 13:30, wrote: --- a/Config.mk +++ b/Config.mk @@ -212,9 +212,6 @@ CFLAGS += -std=gnu99 CFLAGS += -Wall -Ws

Re: [Xen-devel] [PATCH v4 4/4] build: enable no-parentheses in clang

2017-02-14 Thread Andrew Cooper
On 14/02/17 14:06, Roger Pau Monne wrote: > On Tue, Feb 14, 2017 at 06:56:12AM -0700, Jan Beulich wrote: > On 14.02.17 at 13:30, wrote: >>> --- a/Config.mk >>> +++ b/Config.mk >>> @@ -212,9 +212,6 @@ CFLAGS += -std=gnu99 >>> >>> CFLAGS += -Wall -Wstrict-prototypes >>> >>> -# Clang complai

Re: [Xen-devel] [PATCH v4 4/4] build: enable no-parentheses in clang

2017-02-14 Thread Roger Pau Monne
On Tue, Feb 14, 2017 at 06:56:12AM -0700, Jan Beulich wrote: > >>> On 14.02.17 at 13:30, wrote: > > --- a/Config.mk > > +++ b/Config.mk > > @@ -212,9 +212,6 @@ CFLAGS += -std=gnu99 > > > > CFLAGS += -Wall -Wstrict-prototypes > > > > -# Clang complains about macros that expand to 'if ( ( foo =

Re: [Xen-devel] [PATCH v4 4/4] build: enable no-parentheses in clang

2017-02-14 Thread Jan Beulich
>>> On 14.02.17 at 13:30, wrote: > --- a/Config.mk > +++ b/Config.mk > @@ -212,9 +212,6 @@ CFLAGS += -std=gnu99 > > CFLAGS += -Wall -Wstrict-prototypes > > -# Clang complains about macros that expand to 'if ( ( foo == bar ) ) ...' > -CFLAGS-$(clang) += -Wno-parentheses Taking the comment bei

Re: [Xen-devel] [PATCH v4 4/4] build: enable no-parentheses in clang

2017-02-14 Thread Andrew Cooper
On 14/02/17 12:30, Roger Pau Monne wrote: > And fix the following errors reported: > > traps.c:2014:25: error: equality comparison with extraneous parentheses > [-Werror,-Wparentheses-equality] > else if ( (port == RTC_PORT(0)) ) >~^~ > traps.c:2014

[Xen-devel] [PATCH v4 4/4] build: enable no-parentheses in clang

2017-02-14 Thread Roger Pau Monne
And fix the following errors reported: traps.c:2014:25: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality] else if ( (port == RTC_PORT(0)) ) ~^~ traps.c:2014:25: note: remove extraneous parentheses around the com