Re: [Xen-devel] [PATCH v4 3/5] x86emul: make write and cmpxchg hooks optional

2016-12-13 Thread Andrew Cooper
On 13/12/16 11:28, Jan Beulich wrote: > While the read and fetch hooks are basically unavoidable, write and > cmpxchg aren't really needed by that many insns. > > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper ___ Xen-devel mailing list Xen-dev

[Xen-devel] [PATCH v4 3/5] x86emul: make write and cmpxchg hooks optional

2016-12-13 Thread Jan Beulich
While the read and fetch hooks are basically unavoidable, write and cmpxchg aren't really needed by that many insns. Signed-off-by: Jan Beulich --- v4: Don't open-code fail_if(). Add ASSERT()s for fetch and read hooks. Move a write hook check closer to its use, and add ASSERT()s and comme