Re: [Xen-devel] [PATCH v4 3/3] xen: make available hvm_fep to non-debug build as well

2016-06-23 Thread Doug Goldstein
On 6/23/16 10:10 AM, Wei Liu wrote: > Originally hvm_fep was guarded by NDEBUG, which means it was only > available to debug builds. > > However there is value to have it for non-debug builds as well. User can > use that to run tests in setup that replicates production setup. "Users can use it to

Re: [Xen-devel] [PATCH v4 3/3] xen: make available hvm_fep to non-debug build as well

2016-06-23 Thread Andrew Cooper
On 23/06/16 16:26, Wei Liu wrote: > On Thu, Jun 23, 2016 at 04:24:40PM +0100, Andrew Cooper wrote: >> On 23/06/16 16:10, Wei Liu wrote: >>> Originally hvm_fep was guarded by NDEBUG, which means it was only >>> available to debug builds. >>> >>> However there is value to have it for non-debug builds

Re: [Xen-devel] [PATCH v4 3/3] xen: make available hvm_fep to non-debug build as well

2016-06-23 Thread Wei Liu
On Thu, Jun 23, 2016 at 04:24:40PM +0100, Andrew Cooper wrote: > On 23/06/16 16:10, Wei Liu wrote: > > Originally hvm_fep was guarded by NDEBUG, which means it was only > > available to debug builds. > > > > However there is value to have it for non-debug builds as well. User can > > use that to ru

Re: [Xen-devel] [PATCH v4 3/3] xen: make available hvm_fep to non-debug build as well

2016-06-23 Thread Andrew Cooper
On 23/06/16 16:10, Wei Liu wrote: > Originally hvm_fep was guarded by NDEBUG, which means it was only > available to debug builds. > > However there is value to have it for non-debug builds as well. User can > use that to run tests in setup that replicates production setup. That is odd phrasing.

Re: [Xen-devel] [PATCH v4 3/3] xen: make available hvm_fep to non-debug build as well

2016-06-23 Thread Jan Beulich
>>> On 23.06.16 at 17:10, wrote: > Originally hvm_fep was guarded by NDEBUG, which means it was only > available to debug builds. > > However there is value to have it for non-debug builds as well. User can > use that to run tests in setup that replicates production setup. > > Make it clear with

[Xen-devel] [PATCH v4 3/3] xen: make available hvm_fep to non-debug build as well

2016-06-23 Thread Wei Liu
Originally hvm_fep was guarded by NDEBUG, which means it was only available to debug builds. However there is value to have it for non-debug builds as well. User can use that to run tests in setup that replicates production setup. Make it clear with a sync_console style warning that this option c