Re: [Xen-devel] [PATCH v4 2/2] xen/block: add multi-page ring support

2015-05-21 Thread Roger Pau Monné
El 21/05/15 a les 15.03, Bob Liu ha escrit: > On 05/21/2015 07:22 PM, Roger Pau Monné wrote: >> El 20/05/15 a les 15.10, Bob Liu ha escrit: >>> + err = xenbus_scanf(XBT_NIL, dev->otherend, >>> + ring_ref_name, "%u", &ring_ref[i]); >> >> No need

Re: [Xen-devel] [PATCH v4 2/2] xen/block: add multi-page ring support

2015-05-21 Thread Bob Liu
On 05/21/2015 07:22 PM, Roger Pau Monné wrote: > El 20/05/15 a les 15.10, Bob Liu ha escrit: ... >> +} else { >> +unsigned int i; >> + >> +if (ring_page_order > xen_blkif_max_ring_order) { >> +err = -EINVAL; >> +xenbus_dev_fatal(d

Re: [Xen-devel] [PATCH v4 2/2] xen/block: add multi-page ring support

2015-05-21 Thread Roger Pau Monné
El 20/05/15 a les 15.10, Bob Liu ha escrit: > Extend xen/block to support multi-page ring, so that more requests can be > issued > by using more than one pages as the request ring between blkfront and backend. > As a result, the performance can get improved significantly. > > We got some impressi

Re: [Xen-devel] [PATCH v4 2/2] xen/block: add multi-page ring support

2015-05-20 Thread Bob Liu
On 05/20/2015 11:00 PM, Julien Grall wrote: > On 20/05/15 15:56, Roger Pau Monné wrote: >> El 20/05/15 a les 15.21, Julien Grall ha escrit: >>> Hi, >>> >>> On 20/05/15 14:10, Bob Liu wrote: --- drivers/block/xen-blkback/blkback.c | 12 drivers/block/xen-blkback/common.h |

Re: [Xen-devel] [PATCH v4 2/2] xen/block: add multi-page ring support

2015-05-20 Thread Julien Grall
On 20/05/15 15:56, Roger Pau Monné wrote: > El 20/05/15 a les 15.21, Julien Grall ha escrit: >> Hi, >> >> On 20/05/15 14:10, Bob Liu wrote: >>> --- >>> drivers/block/xen-blkback/blkback.c | 12 >>> drivers/block/xen-blkback/common.h | 3 +- >>> drivers/block/xen-blkback/xenbus.c | 85 ++

Re: [Xen-devel] [PATCH v4 2/2] xen/block: add multi-page ring support

2015-05-20 Thread Roger Pau Monné
El 20/05/15 a les 15.21, Julien Grall ha escrit: > Hi, > > On 20/05/15 14:10, Bob Liu wrote: >> --- >> drivers/block/xen-blkback/blkback.c | 12 >> drivers/block/xen-blkback/common.h | 3 +- >> drivers/block/xen-blkback/xenbus.c | 85 +--- >> drivers/block/xen-b

Re: [Xen-devel] [PATCH v4 2/2] xen/block: add multi-page ring support

2015-05-20 Thread Julien Grall
Hi, On 20/05/15 14:10, Bob Liu wrote: > --- > drivers/block/xen-blkback/blkback.c | 12 > drivers/block/xen-blkback/common.h | 3 +- > drivers/block/xen-blkback/xenbus.c | 85 +--- > drivers/block/xen-blkfront.c| 110 > ++

[Xen-devel] [PATCH v4 2/2] xen/block: add multi-page ring support

2015-05-20 Thread Bob Liu
Extend xen/block to support multi-page ring, so that more requests can be issued by using more than one pages as the request ring between blkfront and backend. As a result, the performance can get improved significantly. We got some impressive improvements on our highend iscsi storage cluster bac