Re: [Xen-devel] [PATCH v4 2/2] x86/Intel: virtualize support for cpuid faulting

2016-10-18 Thread Tian, Kevin
> From: Kyle Huey [mailto:m...@kylehuey.com] > Sent: Tuesday, October 18, 2016 2:51 AM > > On HVM guests, the cpuid triggers a vm exit, so we can check the emulated > faulting state in vmx_do_cpuid and hvmemul_cpuid. A new function, > hvm_check_cpuid_fault will check if cpuid faulting is enabled a

Re: [Xen-devel] [PATCH v4 2/2] x86/Intel: virtualize support for cpuid faulting

2016-10-18 Thread Tian, Kevin
> From: Kyle Huey [mailto:m...@kylehuey.com] > Sent: Tuesday, October 18, 2016 9:57 PM > > >> diff --git a/xen/arch/x86/hvm/emulate.c b/xen/arch/x86/hvm/emulate.c > >> index 6ed7486..a713ff3 100644 > >> --- a/xen/arch/x86/hvm/emulate.c > >> +++ b/xen/arch/x86/hvm/emulate.c > >> @@ -1544,16 +1544,3

Re: [Xen-devel] [PATCH v4 2/2] x86/Intel: virtualize support for cpuid faulting

2016-10-18 Thread Kyle Huey
On Tue, Oct 18, 2016 at 3:09 AM, Andrew Cooper wrote: > On 17/10/16 19:51, Kyle Huey wrote: >> diff --git a/xen/arch/x86/hvm/emulate.c b/xen/arch/x86/hvm/emulate.c >> index 6ed7486..a713ff3 100644 >> --- a/xen/arch/x86/hvm/emulate.c >> +++ b/xen/arch/x86/hvm/emulate.c >> @@ -1544,16 +1544,35 @@ st

Re: [Xen-devel] [PATCH v4 2/2] x86/Intel: virtualize support for cpuid faulting

2016-10-18 Thread Kyle Huey
On Tue, Oct 18, 2016 at 1:29 AM, Tian, Kevin wrote: >> From: Kyle Huey [mailto:m...@kylehuey.com] >> Sent: Tuesday, October 18, 2016 2:51 AM >> >> On HVM guests, the cpuid triggers a vm exit, so we can check the emulated >> faulting state in vmx_do_cpuid and hvmemul_cpuid. A new function, >> hvm_c

Re: [Xen-devel] [PATCH v4 2/2] x86/Intel: virtualize support for cpuid faulting

2016-10-18 Thread Andrew Cooper
On 17/10/16 19:51, Kyle Huey wrote: > diff --git a/xen/arch/x86/hvm/emulate.c b/xen/arch/x86/hvm/emulate.c > index 6ed7486..a713ff3 100644 > --- a/xen/arch/x86/hvm/emulate.c > +++ b/xen/arch/x86/hvm/emulate.c > @@ -1544,16 +1544,35 @@ static int hvmemul_wbinvd( > > static int hvmemul_cpuid( >

Re: [Xen-devel] [PATCH v4 2/2] x86/Intel: virtualize support for cpuid faulting

2016-10-18 Thread Tian, Kevin
> From: Kyle Huey [mailto:m...@kylehuey.com] > Sent: Tuesday, October 18, 2016 2:51 AM > > On HVM guests, the cpuid triggers a vm exit, so we can check the emulated > faulting state in vmx_do_cpuid and hvmemul_cpuid. A new function, > hvm_check_cpuid_fault will check if cpuid faulting is enabled a

[Xen-devel] [PATCH v4 2/2] x86/Intel: virtualize support for cpuid faulting

2016-10-17 Thread Kyle Huey
On HVM guests, the cpuid triggers a vm exit, so we can check the emulated faulting state in vmx_do_cpuid and hvmemul_cpuid. A new function, hvm_check_cpuid_fault will check if cpuid faulting is enabled and the CPL > 0. When it returns true, the cpuid handling functions will inject a GP(0). Notably