Re: [Xen-devel] [PATCH v4 2/2] IB/qib: use arch_phys_wc_add()

2015-04-22 Thread Luis R. Rodriguez
On Wed, Apr 22, 2015 at 01:48:27PM -0400, Doug Ledford wrote: > On Wed, 2015-04-22 at 19:37 +0200, Luis R. Rodriguez wrote: > > On Wed, Apr 22, 2015 at 12:57:18PM -0400, Doug Ledford wrote: > > > On Wed, 2015-04-22 at 17:33 +0200, Luis R. Rodriguez wrote: > > > > On Wed, Apr 22, 2015 at 09:54:38AM

Re: [Xen-devel] [PATCH v4 2/2] IB/qib: use arch_phys_wc_add()

2015-04-22 Thread Doug Ledford
On Wed, 2015-04-22 at 19:37 +0200, Luis R. Rodriguez wrote: > On Wed, Apr 22, 2015 at 12:57:18PM -0400, Doug Ledford wrote: > > On Wed, 2015-04-22 at 17:33 +0200, Luis R. Rodriguez wrote: > > > On Wed, Apr 22, 2015 at 09:54:38AM -0400, Doug Ledford wrote: > > > > On Tue, 2015-04-21 at 14:50 -0700,

Re: [Xen-devel] [PATCH v4 2/2] IB/qib: use arch_phys_wc_add()

2015-04-22 Thread Luis R. Rodriguez
On Wed, Apr 22, 2015 at 12:57:18PM -0400, Doug Ledford wrote: > On Wed, 2015-04-22 at 17:33 +0200, Luis R. Rodriguez wrote: > > On Wed, Apr 22, 2015 at 09:54:38AM -0400, Doug Ledford wrote: > > > On Tue, 2015-04-21 at 14:50 -0700, Luis R. Rodriguez wrote: > > > > > > This: > > > > + /* MTRR

Re: [Xen-devel] [PATCH v4 2/2] IB/qib: use arch_phys_wc_add()

2015-04-22 Thread Doug Ledford
On Wed, 2015-04-22 at 17:33 +0200, Luis R. Rodriguez wrote: > On Wed, Apr 22, 2015 at 09:54:38AM -0400, Doug Ledford wrote: > > On Tue, 2015-04-21 at 14:50 -0700, Luis R. Rodriguez wrote: > > > > This: > > > + /* MTRR was used if this is non-zero */ > > > + if (!dd->wc_cookie) > > > vma-

Re: [Xen-devel] [PATCH v4 2/2] IB/qib: use arch_phys_wc_add()

2015-04-22 Thread Luis R. Rodriguez
On Wed, Apr 22, 2015 at 09:54:38AM -0400, Doug Ledford wrote: > On Tue, 2015-04-21 at 14:50 -0700, Luis R. Rodriguez wrote: > > This: > > + /* MTRR was used if this is non-zero */ > > + if (!dd->wc_cookie) > > vma->vm_page_prot = pgprot_writecombine(vma->vm_page_prot); > > And thi

Re: [Xen-devel] [PATCH v4 2/2] IB/qib: use arch_phys_wc_add()

2015-04-22 Thread Doug Ledford
On Tue, 2015-04-21 at 14:50 -0700, Luis R. Rodriguez wrote: This: > + /* MTRR was used if this is non-zero */ > + if (!dd->wc_cookie) > vma->vm_page_prot = pgprot_writecombine(vma->vm_page_prot); And this: > + dd->wc_cookie = arch_phys_wc_add(pioaddr, piolen); >

Re: [Xen-devel] [PATCH v4 2/2] IB/qib: use arch_phys_wc_add()

2015-04-21 Thread Jason Gunthorpe
On Tue, Apr 21, 2015 at 02:50:35PM -0700, Luis R. Rodriguez wrote: > - if (qib_wc_pat) { > - resource_size_t vl15off; > - /* > - * We do not set WC on the VL15 buffers to avoid > - * a rare problem with unaligned writes from > - * i

[Xen-devel] [PATCH v4 2/2] IB/qib: use arch_phys_wc_add()

2015-04-21 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" This driver already makes use of ioremap_wc() on PIO buffers, so convert it to use arch_phys_wc_add(). The qib driver uses a mmap() special case for when PAT is not used, this behaviour used to be determined with a module parameter but since we have been asked to just r