Re: [Xen-devel] [PATCH v4 14/24] arm/acpi: Prepare EFI system table for Dom0

2016-03-04 Thread Stefano Stabellini
On Fri, 4 Mar 2016, Shannon Zhao wrote: > On 2016/3/1 20:49, Stefano Stabellini wrote: > > On Tue, 1 Mar 2016, Jan Beulich wrote: > > > >>> On 01.03.16 at 03:35, wrote: > >> > > >>> > > > >>> > > On 2016/2/29 22:36, Jan Beulich wrote: > >>> > > On 29.02.16 at 15:25, > >>> > >>>

Re: [Xen-devel] [PATCH v4 14/24] arm/acpi: Prepare EFI system table for Dom0

2016-03-03 Thread Shannon Zhao
On 2016/3/1 20:49, Stefano Stabellini wrote: > On Tue, 1 Mar 2016, Jan Beulich wrote: > > >>> On 01.03.16 at 03:35, wrote: >> > >>> > > >>> > > On 2016/2/29 22:36, Jan Beulich wrote: >>> > > On 29.02.16 at 15:25, wrote: >> > >>> > On Mon, 29 Feb 2016, Jan Beulich wrote: >>

Re: [Xen-devel] [PATCH v4 14/24] arm/acpi: Prepare EFI system table for Dom0

2016-03-01 Thread Stefano Stabellini
On Tue, 1 Mar 2016, Jan Beulich wrote: > >>> On 01.03.16 at 03:35, wrote: > > > > > On 2016/2/29 22:36, Jan Beulich wrote: > > On 29.02.16 at 15:25, wrote: > >>> > On Mon, 29 Feb 2016, Jan Beulich wrote: > >> Also it doesn't look very nice to me to (ab)use xz's CRC32 code > >> her

Re: [Xen-devel] [PATCH v4 14/24] arm/acpi: Prepare EFI system table for Dom0

2016-03-01 Thread Jan Beulich
>>> On 01.03.16 at 03:35, wrote: > > On 2016/2/29 22:36, Jan Beulich wrote: > On 29.02.16 at 15:25, wrote: >>> > On Mon, 29 Feb 2016, Jan Beulich wrote: >> Also it doesn't look very nice to me to (ab)use xz's CRC32 code >> here; I don't know who has suggested doing so. >>> > >>>

Re: [Xen-devel] [PATCH v4 14/24] arm/acpi: Prepare EFI system table for Dom0

2016-02-29 Thread Shannon Zhao
On 2016/2/29 22:36, Jan Beulich wrote: On 29.02.16 at 15:25, wrote: >> > On Mon, 29 Feb 2016, Jan Beulich wrote: >>> >> Also it doesn't look very nice to me to (ab)use xz's CRC32 code >>> >> here; I don't know who has suggested doing so. >> > >> > It was suggested by Julien. >> > >> > I

Re: [Xen-devel] [PATCH v4 14/24] arm/acpi: Prepare EFI system table for Dom0

2016-02-29 Thread Stefano Stabellini
On Mon, 29 Feb 2016, Jan Beulich wrote: > >>> On 29.02.16 at 15:25, wrote: > > On Mon, 29 Feb 2016, Jan Beulich wrote: > >> Also it doesn't look very nice to me to (ab)use xz's CRC32 code > >> here; I don't know who has suggested doing so. > > > > It was suggested by Julien. > > > > I agree tha

Re: [Xen-devel] [PATCH v4 14/24] arm/acpi: Prepare EFI system table for Dom0

2016-02-29 Thread Jan Beulich
>>> On 29.02.16 at 15:25, wrote: > On Mon, 29 Feb 2016, Jan Beulich wrote: >> Also it doesn't look very nice to me to (ab)use xz's CRC32 code >> here; I don't know who has suggested doing so. > > It was suggested by Julien. > > I agree that including ../../../common/xz/crc32.c seems a bit fragi

Re: [Xen-devel] [PATCH v4 14/24] arm/acpi: Prepare EFI system table for Dom0

2016-02-29 Thread Stefano Stabellini
On Mon, 29 Feb 2016, Jan Beulich wrote: > >>> On 28.02.16 at 12:19, wrote: > > --- a/xen/common/efi/boot.c > > +++ b/xen/common/efi/boot.c > > @@ -1173,6 +1173,10 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE > > *SystemTable) > > } > > > > #if defined (CONFIG_ACPI) && defined (CONFIG

Re: [Xen-devel] [PATCH v4 14/24] arm/acpi: Prepare EFI system table for Dom0

2016-02-29 Thread Jan Beulich
>>> On 28.02.16 at 12:19, wrote: > --- a/xen/common/efi/boot.c > +++ b/xen/common/efi/boot.c > @@ -1173,6 +1173,10 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE > *SystemTable) > } > > #if defined (CONFIG_ACPI) && defined (CONFIG_ARM) > +#include "../../../common/decompress.h" > +#def

[Xen-devel] [PATCH v4 14/24] arm/acpi: Prepare EFI system table for Dom0

2016-02-28 Thread Shannon Zhao
From: Shannon Zhao Prepare EFI system table for Dom0 to describe the information of UEFI. Cc: Jan Beulich Signed-off-by: Parth Dixit Signed-off-by: Shannon Zhao --- v4: use already existing xz_crc32_init and xz_crc32 --- xen/arch/arm/domain_build.c | 2 ++ xen/common/efi/boot.c | 44 +