Re: [Xen-devel] [PATCH v4 12/24] arm/p2m: Add helper functions to map memory regions

2016-02-29 Thread Stefano Stabellini
On Sun, 28 Feb 2016, Shannon Zhao wrote: > From: Parth Dixit > > Create a helper function for mapping with cached attributes and > read-only range. > > Signed-off-by: Parth Dixit > Signed-off-by: Shannon Zhao This is good, but for clarity please rename the two functions to map_regions_ro and

[Xen-devel] [PATCH v4 12/24] arm/p2m: Add helper functions to map memory regions

2016-02-28 Thread Shannon Zhao
From: Parth Dixit Create a helper function for mapping with cached attributes and read-only range. Signed-off-by: Parth Dixit Signed-off-by: Shannon Zhao --- v4: use p2m_access_r --- xen/arch/arm/p2m.c| 26 ++ xen/include/asm-arm/p2m.h | 10 ++ 2 files