Re: [Xen-devel] [PATCH v4 1/9] livepatch: Clear .bss when payload is reverted

2016-09-09 Thread Jan Beulich
>>> On 09.09.16 at 15:50, wrote: > On Fri, Sep 09, 2016 at 02:33:18PM +0100, Ross Lagerwall wrote: >> On 08/24/2016 03:22 AM, Konrad Rzeszutek Wilk wrote: >> > So that when we apply the patch again the .bss is cleared. >> > Otherwise we may find some variables containing old values. >> > >> > The

Re: [Xen-devel] [PATCH v4 1/9] livepatch: Clear .bss when payload is reverted

2016-09-09 Thread Ross Lagerwall
On 09/09/2016 02:50 PM, Konrad Rzeszutek Wilk wrote: On Fri, Sep 09, 2016 at 02:33:18PM +0100, Ross Lagerwall wrote: On 08/24/2016 03:22 AM, Konrad Rzeszutek Wilk wrote: So that when we apply the patch again the .bss is cleared. Otherwise we may find some variables containing old values. The p

Re: [Xen-devel] [PATCH v4 1/9] livepatch: Clear .bss when payload is reverted

2016-09-09 Thread Konrad Rzeszutek Wilk
On Fri, Sep 09, 2016 at 02:33:18PM +0100, Ross Lagerwall wrote: > On 08/24/2016 03:22 AM, Konrad Rzeszutek Wilk wrote: > > So that when we apply the patch again the .bss is cleared. > > Otherwise we may find some variables containing old values. > > > > The payloads may contain various .bss - espe

Re: [Xen-devel] [PATCH v4 1/9] livepatch: Clear .bss when payload is reverted

2016-09-09 Thread Ross Lagerwall
On 08/24/2016 03:22 AM, Konrad Rzeszutek Wilk wrote: So that when we apply the patch again the .bss is cleared. Otherwise we may find some variables containing old values. The payloads may contain various .bss - especially if -fdata-sections is used which can create .bss. sections. After havi

Re: [Xen-devel] [PATCH v4 1/9] livepatch: Clear .bss when payload is reverted

2016-09-08 Thread Konrad Rzeszutek Wilk
On Wed, Sep 07, 2016 at 02:02:44AM -0600, Jan Beulich wrote: > >>> On 06.09.16 at 18:47, wrote: > > On Wed, Aug 24, 2016 at 02:55:21AM -0600, Jan Beulich wrote: > >> >>> On 24.08.16 at 04:22, wrote: > >> > --- a/xen/common/livepatch.c > >> > +++ b/xen/common/livepatch.c > >> > @@ -70,6 +70,9 @@ s

Re: [Xen-devel] [PATCH v4 1/9] livepatch: Clear .bss when payload is reverted

2016-09-07 Thread Jan Beulich
>>> On 06.09.16 at 18:51, wrote: > --- a/xen/common/livepatch_elf.c > +++ b/xen/common/livepatch_elf.c > @@ -86,7 +86,16 @@ static int elf_resolve_sections(struct livepatch_elf *elf, > const void *data) > delta < sizeof(Elf_Ehdr) ? "at ELF header" : "is past > end"); >

Re: [Xen-devel] [PATCH v4 1/9] livepatch: Clear .bss when payload is reverted

2016-09-07 Thread Jan Beulich
>>> On 06.09.16 at 18:47, wrote: > On Wed, Aug 24, 2016 at 02:55:21AM -0600, Jan Beulich wrote: >> >>> On 24.08.16 at 04:22, wrote: >> > --- a/xen/common/livepatch.c >> > +++ b/xen/common/livepatch.c >> > @@ -70,6 +70,9 @@ struct payload { >> > unsigned int nsyms; /* Nr of e

Re: [Xen-devel] [PATCH v4 1/9] livepatch: Clear .bss when payload is reverted

2016-09-06 Thread Konrad Rzeszutek Wilk
On Thu, Aug 25, 2016 at 05:08:16PM +0100, Andrew Cooper wrote: > On 24/08/16 09:55, Jan Beulich wrote: > > > > > On 24.08.16 at 04:22, wrote: > > > --- a/xen/common/livepatch.c > > > +++ b/xen/common/livepatch.c > > > @@ -70,6 +70,9 @@ struct payload { > > > unsigned int nsyms;

Re: [Xen-devel] [PATCH v4 1/9] livepatch: Clear .bss when payload is reverted

2016-09-06 Thread Konrad Rzeszutek Wilk
On Wed, Aug 24, 2016 at 02:55:21AM -0600, Jan Beulich wrote: > >>> On 24.08.16 at 04:22, wrote: > > --- a/xen/common/livepatch.c > > +++ b/xen/common/livepatch.c > > @@ -70,6 +70,9 @@ struct payload { > > unsigned int nsyms; /* Nr of entries in .strtab and > > symbols. */ >

Re: [Xen-devel] [PATCH v4 1/9] livepatch: Clear .bss when payload is reverted

2016-08-25 Thread Andrew Cooper
On 24/08/16 09:55, Jan Beulich wrote: On 24.08.16 at 04:22, wrote: --- a/xen/common/livepatch.c +++ b/xen/common/livepatch.c @@ -70,6 +70,9 @@ struct payload { unsigned int nsyms; /* Nr of entries in .strtab and symbols. */ struct livepatch_build_id id;/* E

Re: [Xen-devel] [PATCH v4 1/9] livepatch: Clear .bss when payload is reverted

2016-08-24 Thread Jan Beulich
>>> On 24.08.16 at 04:22, wrote: > --- a/xen/common/livepatch.c > +++ b/xen/common/livepatch.c > @@ -70,6 +70,9 @@ struct payload { > unsigned int nsyms; /* Nr of entries in .strtab and > symbols. */ > struct livepatch_build_id id;/* ELFNOTE_DESC(.note.gnu.build

[Xen-devel] [PATCH v4 1/9] livepatch: Clear .bss when payload is reverted

2016-08-23 Thread Konrad Rzeszutek Wilk
So that when we apply the patch again the .bss is cleared. Otherwise we may find some variables containing old values. The payloads may contain various .bss - especially if -fdata-sections is used which can create .bss. sections. Signed-off-by: Konrad Rzeszutek Wilk --- Cc: Ross Lagerwall Cc: