Re: [Xen-devel] [PATCH v4 1/2] arm: read/write rank->vcpu atomically

2017-02-16 Thread Stefano Stabellini
On Thu, 16 Feb 2017, Julien Grall wrote: > Hi Stefano, > > On 11/02/17 02:05, Stefano Stabellini wrote: > > We don't need a lock in vgic_get_target_vcpu anymore, solving the > > following lock inversion bug: the rank lock should be taken first, then > > the vgic lock. However, gic_update_one_lr is

Re: [Xen-devel] [PATCH v4 1/2] arm: read/write rank->vcpu atomically

2017-02-16 Thread Julien Grall
Hi Stefano, On 11/02/17 02:05, Stefano Stabellini wrote: We don't need a lock in vgic_get_target_vcpu anymore, solving the following lock inversion bug: the rank lock should be taken first, then the vgic lock. However, gic_update_one_lr is called with the vgic lock held, and it calls vgic_get_ta

[Xen-devel] [PATCH v4 1/2] arm: read/write rank->vcpu atomically

2017-02-10 Thread Stefano Stabellini
We don't need a lock in vgic_get_target_vcpu anymore, solving the following lock inversion bug: the rank lock should be taken first, then the vgic lock. However, gic_update_one_lr is called with the vgic lock held, and it calls vgic_get_target_vcpu, which tries to obtain the rank lock. Coverity-ID