Re: [Xen-devel] [PATCH v4 08/14] hvmloader: Locate the BIOS blob

2016-04-07 Thread Jan Beulich
>>> On 07.04.16 at 17:10, wrote: > On Tue, Apr 05, 2016 at 06:59:03AM -0600, Jan Beulich wrote: >> >>> On 14.03.16 at 18:55, wrote: >> > --- a/tools/firmware/hvmloader/hvmloader.c >> > +++ b/tools/firmware/hvmloader/hvmloader.c >> > @@ -292,8 +322,16 @@ int main(void) >> > } >> > >> >

Re: [Xen-devel] [PATCH v4 08/14] hvmloader: Locate the BIOS blob

2016-04-07 Thread Anthony PERARD
On Tue, Apr 05, 2016 at 06:59:03AM -0600, Jan Beulich wrote: > >>> On 14.03.16 at 18:55, wrote: > > --- a/tools/firmware/hvmloader/hvmloader.c > > +++ b/tools/firmware/hvmloader/hvmloader.c > > @@ -292,8 +322,16 @@ int main(void) > > } > > > > printf("Loading %s ...\n", bios->name); >

Re: [Xen-devel] [PATCH v4 08/14] hvmloader: Locate the BIOS blob

2016-04-05 Thread Jan Beulich
>>> On 05.04.16 at 16:05, wrote: > On Tue, 5 Apr 2016, Jan Beulich wrote: >> >>> On 14.03.16 at 18:55, wrote: >> > --- a/tools/firmware/hvmloader/hvmloader.c >> > +++ b/tools/firmware/hvmloader/hvmloader.c >> > @@ -253,10 +253,40 @@ static void acpi_enable_sci(void) >> > BUG_ON(!(pm1a_cnt_va

Re: [Xen-devel] [PATCH v4 08/14] hvmloader: Locate the BIOS blob

2016-04-05 Thread Roger Pau Monné
On Tue, 5 Apr 2016, Jan Beulich wrote: > >>> On 14.03.16 at 18:55, wrote: > > --- a/tools/firmware/hvmloader/hvmloader.c > > +++ b/tools/firmware/hvmloader/hvmloader.c > > @@ -253,10 +253,40 @@ static void acpi_enable_sci(void) > > BUG_ON(!(pm1a_cnt_val & ACPI_PM1C_SCI_EN)); > > } > > > >

Re: [Xen-devel] [PATCH v4 08/14] hvmloader: Locate the BIOS blob

2016-04-05 Thread Jan Beulich
>>> On 14.03.16 at 18:55, wrote: > --- a/tools/firmware/hvmloader/hvmloader.c > +++ b/tools/firmware/hvmloader/hvmloader.c > @@ -253,10 +253,40 @@ static void acpi_enable_sci(void) > BUG_ON(!(pm1a_cnt_val & ACPI_PM1C_SCI_EN)); > } > > +const struct hvm_modlist_entry *get_module_entry( > +

Re: [Xen-devel] [PATCH v4 08/14] hvmloader: Locate the BIOS blob

2016-03-20 Thread Konrad Rzeszutek Wilk
> I'll do that. I'm using to many BUG_ON in this code. > > > > +{ > > > +BUG_ON(!modlist[i].paddr || modlist[i].paddr > UINT_MAX || > > > + modlist[i].size > UINT_MAX); > > > > To be fair all of those values are in spec..Perhaps you should mention > > that th

Re: [Xen-devel] [PATCH v4 08/14] hvmloader: Locate the BIOS blob

2016-03-19 Thread Jan Beulich
>>> On 17.03.16 at 18:46, wrote: > On Tue, Mar 15, 2016 at 09:14:17PM -0400, Konrad Rzeszutek Wilk wrote: >> On Mon, Mar 14, 2016 at 05:55:43PM +, Anthony PERARD wrote: >> > The BIOS can be found an entry called "bios" of the modlist of the >> >> s/BIOS/BIOS blob/ >> > hvm_start_info struct.

Re: [Xen-devel] [PATCH v4 08/14] hvmloader: Locate the BIOS blob

2016-03-19 Thread Anthony PERARD
On Tue, Mar 15, 2016 at 09:14:17PM -0400, Konrad Rzeszutek Wilk wrote: > On Mon, Mar 14, 2016 at 05:55:43PM +, Anthony PERARD wrote: > > The BIOS can be found an entry called "bios" of the modlist of the > > s/BIOS/BIOS blob/ > > hvm_start_info struct. > > > > The found BIOS blob is not loade

Re: [Xen-devel] [PATCH v4 08/14] hvmloader: Locate the BIOS blob

2016-03-15 Thread Konrad Rzeszutek Wilk
On Mon, Mar 14, 2016 at 05:55:43PM +, Anthony PERARD wrote: > The BIOS can be found an entry called "bios" of the modlist of the s/BIOS/BIOS blob/ > hvm_start_info struct. > > The found BIOS blob is not loaded by this patch, but only passed as > argument to bios_load() function. It is going t

[Xen-devel] [PATCH v4 08/14] hvmloader: Locate the BIOS blob

2016-03-14 Thread Anthony PERARD
The BIOS can be found an entry called "bios" of the modlist of the hvm_start_info struct. The found BIOS blob is not loaded by this patch, but only passed as argument to bios_load() function. It is going to be used by the next few patches. Signed-off-by: Anthony PERARD --- Changes in V4: - add